Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite ResNet sample by GCP components #1018

Merged
merged 7 commits into from
Apr 8, 2019
Merged

Rewrite ResNet sample by GCP components #1018

merged 7 commits into from
Apr 8, 2019

Conversation

hongye-sun
Copy link
Contributor

@hongye-sun hongye-sun commented Mar 22, 2019 •
edited
Loading

The PR includes:

  • Rewrite samples/resnet-cmle by using GCP components from components/gcp folder.
  • Moved components/resnet-cmle/resnet/resnet_model/trainer/preprocess.py to samples/resnet-cmle/preprocess/preprocess.py.
  • Moved components/resnet-cmle/resnet/resnet_model/trainer to samples/resnet-cmle/trainer
  • Remove wrapper classes under components/resnet-cmle/resnet
  • Remove container files under components/resnet-cmle/containers

This change is Reviewable

@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 22, 2019

The PR also removes old ResNet container code.

Do you think they might be still be useful for the CMLE container training?

@hongye-sun
Copy link
Contributor Author

Alexey, I am not sure where it is going to be used, do you know any user is using that?

@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 26, 2019

Alexey, I am not sure where it is going to be used, do you know any user is using that?

Probably no one is using them. I thought they might be useful to demonstrate using the same container to train on both CMLE and TFJob.

/lgtm

@Ark-kun
Copy link
Contributor

Ark-kun commented Apr 4, 2019

Can you please add a bit more information here about what code is just moved, what code is remove and what code is added.

I see that some component code is just moved, but I'm not completely sure about some other code files.

Thanks.
/lgtm

@hongye-sun
Copy link
Contributor Author

Done and need another LGTM. Thanks.

@hongye-sun
Copy link
Contributor Author

/retest

@Ark-kun
Copy link
Contributor

Ark-kun commented Apr 6, 2019

/lgtm

@hongye-sun
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fee1aea into kubeflow:master Apr 8, 2019
@Ark-kun
Copy link
Contributor

Ark-kun commented Apr 10, 2019

CloudBuild is failing:

Starting Step #26 - "buildResnetCMLEDeployComponent"
Step #26 - "buildResnetCMLEDeployComponent": Already have image (with digest): gcr.io/cloud-builders/docker
Step #26 - "buildResnetCMLEDeployComponent": /bin/bash: line 0: cd: /workspace/components/resnet-cmle/containers/deploy: No such file or directory

When deleting files we should make sure they're not mentioned anywhere:
https://github.com/kubeflow/pipelines/search?q=%22components%2Fresnet-cmle%22&unscoped_q=%22components%2Fresnet-cmle%22

@Ark-kun Ark-kun mentioned this pull request Apr 10, 2019
Closed
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
@chensun
Upgrade to kfp 2.0.0-alpha.5 (kubeflow#1018)
a37f715
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@ellistarn
Genericized component logic; cleaned up valdation and other interfaces (
ba529ad 
kubeflow#1018)

* Genericized component logic and cleaned up valdation and other interfaces

* Fixed a validation bug for custom components

* Moved component validation logic to component.go
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
@Tomcli
fix(backend): fix cache server output (kubeflow#1018)
4240890
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

@gaoning777 gaoning777 Awaiting requested review from gaoning777

Assignees

@Ark-kun Ark-kun

@gaoning777 gaoning777

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hongye-sun @Ark-kun @k8s-ci-robot @gaoning777