Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sidebar styling #1010

Merged
merged 2 commits into from
Mar 21, 2019
Merged

Update sidebar styling #1010

merged 2 commits into from
Mar 21, 2019

Conversation

rileyjbauer
Copy link
Contributor

@rileyjbauer rileyjbauer commented Mar 20, 2019 •
edited by jlewi
Loading

Changes sidenav to lower-contrast gray instead of blue. Updates selection and hover styling as well.

Addresses kubeflow/kubeflow#2678

image

This change is Reviewable

@vicaire
Copy link
Contributor

vicaire commented Mar 21, 2019

Assuming Ajay approves the style changes, this looks good to me.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vicaire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vicaire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a60355a into kubeflow:master Mar 21, 2019
@ajayalfred
Copy link
Contributor

Design changes lgtm.

@rileyjbauer rileyjbauer deleted the update-sidebar-styling branch May 6, 2019 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicaire vicaire Awaiting requested review from vicaire

@yebrahim yebrahim Awaiting requested review from yebrahim

@IronPan IronPan Awaiting requested review from IronPan

Assignees

@IronPan IronPan

@ajayalfred ajayalfred

@avdaredevil avdaredevil

@vicaire vicaire

Labels
approved area/frontend lgtm size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rileyjbauer @vicaire @k8s-ci-robot @ajayalfred @IronPan @avdaredevil