SDK/DSL/Compiler - Fixed handling of empty pipeline name #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ark-kun
changed the title
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ark-kun
deleted the
SDK/DSL/Compileer---Fixed-handling-empty-pipeline-name
branch
Linchin
pushed a commit
to Linchin/pipelines
that referenced
this pull request
Apr 11, 2023
This reverts commit 6d60976.
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
* trained model api * remove frameworks' version information
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
* Trained model api (kubeflow#1009) * trained model api * remove frameworks' version information trainedmodel related code add groupversion_info generate deepcopy add v1beta1 serving api remove InferenceService depedency fix optional comment rename MultiModelConfigMapName to ModelConfigMapName and rename tainedmodel to tm rename multiModelConfigMapName to modelConfigName initialize trainedmodel controller rename multimodelconfig pkg to modelconfig refactor shardingstrategy refactor strategy generate crd * rebase master * update modelconfig when reconciling TrainedModel * create an instance of modelconfig reconciler in trainedmodel controller's loop otherwise the reconciler is a nil pointer * add unit test * rename * rename * fix unit tests * revert changes for v1alpha2/openapi_generated.go * remove config/crd/serving.kubeflow.org_inferencerouters.yaml * rename MultiModelConfigVolumeName to ModelConfigVolumeName * rename trainedmodel's predictorModel to inference * inline error check * fix log * annotate error * remove unnecessary error check * rename package * remove unit test for delete as it does not trigger a delete event * refactor sharding strategy * rename configmap to modelConfig * rename ConfigMapReconciler to ModelConfigReconciler * fmt * pass modelconfig reconciler to TrainedModelReconciler as a field * rename TrainedModelSpec.Inference to TrainedModelSpec.model * change Result{Requeue: true, RequeueAfter: 10 * time.Second} to Result{} since the framework will requeue when err is not nil * fix plural name * fix description * fix unit test name * add argo retry * changne retry to 3 * add comma * revert makefile so it only deploys v1alpha1 * register v1beta1 scheme * fix trainedmodel rbac * fix trainedmodel crd per kubernetes-retired/cluster-registry#255 * fix trainedmodel crd from makefile * run make manifests * clean up * fix comment * install kfserving sdk to user home folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #825
This change is