Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenVINO Model Server deployer #1008

Merged
merged 4 commits into from
Mar 23, 2019
Merged

Conversation

dtrawins
Copy link
Contributor

@dtrawins dtrawins commented Mar 20, 2019

New component with exemplary pipeline implementation


This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @dtrawins. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@k8s-ci-robot
Copy link
Contributor

Hi @dtrawins. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 20, 2019

/ok-to-test

@Ark-kun Ark-kun self-assigned this Mar 21, 2019
@dtrawins
Copy link
Contributor Author

@Ark-kun I've just added to the pipeline also a complementary evaluation function. Now the second job is running inference calls over grpc and collects metrics related to accuracy and latency

@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 22, 2019

/lgtm
/approve

@vicaire
Copy link
Contributor

vicaire commented Mar 23, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun, vicaire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun, vicaire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 18ab70c into kubeflow:master Mar 23, 2019
metrics:
- name: latency
- name: accuracy
implementation:
Copy link
Contributor

@sasha-gitg sasha-gitg Jun 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kubeflow components do not support multiple containers in one component. Best to break these out into two components.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also "metrics" attribute has never existed.

magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
…es (kubeflow#1008)

* Add report cards

* Add shields.io badges

* Fix badges

* Update ingress access instruction

* Update min requirement

* Add link for minikube

* Update ingress access instruction for examples

* Update link

* Add istio link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants