SDK/Tests - Simplified type compatibility tests #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplified the type compatibility tests by removing component inputs/outputs and properties that are not required for the tests to work. Renamed (+split) some of the tests: `test_type_check_all_with_types` -> `test_type_compatibility_check_for_simple_types` + `test_type_compatibility_check_for_types_with_parameters` `test_type_check_with_lacking_types` -> `test_type_compatibility_check_when_input_type_is_missing` + `test_type_compatibility_check_when_argument_type_is_missing` `test_type_check_with_inconsistent_types_property_value` -> `test_fail_type_compatibility_check_when_type_property_value_is_different` `test_type_check_with_inconsistent_types_type_name` -> `test_fail_type_compatibility_check_when_simple_type_name_is_different + test_fail_type_compatibility_check_when_parametrized_type_name_is_different` `test_type_check_with_consistent_types_nonnamed_inputs` -> `test_type_compatibility_check_when_using_positional_arguments` `test_type_check_with_inconsistent_types_disabled` ->` test_type_compatibility_check_not_failing_when_disabled` `test_type_check_with_openapi_shema` -> `test_type_compatibility_check_for_types_with_schema` `test_type_check_ignore_type` -> test_fail_type_compatibility_check_for_types_with_different_schemas` + `test_type_compatibility_check_not_failing_when_type_is_ignored` Added two disabled tests: `test_type_compatibility_check_when_argument_type_has_extra_type_parameters` `test_fail_type_compatibility_check_when_argument_type_has_missing_type_parameters`
gaoning777
reviewed
Mar 26, 2019
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
…flow#1078) * support generic filename for ONNX runtime model (kubeflow#1004) * fix file ext * add tests * add url.Parse validation * validate file ext: only allow .onnx in storageUri * default model.onnx for object stores
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified the type compatibility tests by removing component inputs/outputs and properties that are not required for the tests to work.
Renamed (+split) some of the tests:
test_type_check_all_with_types->test_type_compatibility_check_for_simple_types+test_type_compatibility_check_for_types_with_parameterstest_type_check_with_lacking_types->test_type_compatibility_check_when_input_type_is_missing+test_type_compatibility_check_when_argument_type_is_missingtest_type_check_with_inconsistent_types_property_value->test_fail_type_compatibility_check_when_type_property_value_is_differenttest_type_check_with_inconsistent_types_type_name->test_fail_type_compatibility_check_when_simple_type_name_is_different+test_fail_type_compatibility_check_when_parametrized_type_name_is_differenttest_type_check_with_consistent_types_nonnamed_inputs->test_type_compatibility_check_when_using_positional_argumentstest_type_check_with_inconsistent_types_disabled->test_type_compatibility_check_not_failing_when_disabledtest_type_check_with_openapi_shema->test_type_compatibility_check_for_types_with_schematest_type_check_ignore_type->test_fail_type_compatibility_check_for_types_with_different_schemas+test_type_compatibility_check_not_failing_when_type_is_ignoredAdded two disabled tests:
test_type_compatibility_check_when_argument_type_has_extra_type_parameterstest_fail_type_compatibility_check_when_argument_type_has_missing_type_parametersThis change is