Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(backend): Update healthz service in KFP v2 #8833

Closed
Tracked by #10402 ...
gkcalat opened this issue Feb 9, 2023 · 7 comments
Closed
Tracked by #10402 ...

feature(backend): Update healthz service in KFP v2 #8833

gkcalat opened this issue Feb 9, 2023 · 7 comments
Assignees
Labels
area/backend kind/feature lifecycle/stale The issue / pull request is stale, any activities remove this label.

Comments

@gkcalat
Copy link
Member

gkcalat commented Feb 9, 2023

Current state:

KFP v2 inherited HealthzSerivce from KFP v1:

service HealthzService {
  // Get healthz data.
  rpc GetHealthz(google.protobuf.Empty) returns (GetHealthzResponse) {
    option (google.api.http) = {
      get: "/apis/v2beta1/healthz"
    };
  }
}

message GetHealthzResponse {
  // TODO(gkcalat): redesign this service to return status
  // and move server configuration into a separate service
  // TODO(gkcalat): rename or deprecate v1beta1 HealthzService
  // 
  // Returns if KFP in multi-user mode
  bool multi_user = 3;
}

We need to:

  1. Make the service consistent with its purpose and compliant with AIP
  2. Move multi_user and other server configuration-related information to a separate service

Love this idea? Give it a 👍.

@gkcalat gkcalat mentioned this issue Feb 9, 2023
66 tasks
@gkcalat gkcalat self-assigned this Mar 10, 2023
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Aug 26, 2023
Copy link

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

@thesuperzapper
Copy link
Member

/reopen

@google-oss-prow google-oss-prow bot reopened this Nov 30, 2023
Copy link

@thesuperzapper: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions github-actions bot removed the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Dec 1, 2023
@DharmitD
Copy link
Contributor

@gkcalat @chensun could you elaborate on what the "AIP compliance" means? And where could I find relevant guidelines?

@chensun chensun mentioned this issue Jan 16, 2024
18 tasks
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Mar 12, 2024
Copy link

github-actions bot commented Apr 8, 2024

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

@github-actions github-actions bot closed this as completed Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backend kind/feature lifecycle/stale The issue / pull request is stale, any activities remove this label.
Projects
Status: Backlog
Development

No branches or pull requests

4 participants