-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for Docker-in-Docker in DSL (See https://github.com/argoproj/argo/tree/master/examples#docker-in-docker-using-sidecars) #759
Comments
I think one option would be to have your pipeline step run a separate K8s job. Then you could set whatever options (e.g. DockerInDocker, Security context are needed). |
@cliveseldon - Please take a look at the KFP SDK, and the methods that allow building containers from Python functions. The SDK is creating a K8S job for building containers images, you can either use the SDK within a pipeline step or use the same technique for creating an image. Please let me know if that works. |
@cliveseldon, Argo supports building containers inside containers. See https://github.com/argoproj/argo/tree/master/examples#docker-in-docker-using-sidecars Would making this functionality available from the DSL work for you? |
Sorry, missed this. Yes that would be very useful if there was easy access to docker-in-docker. |
/cc @hongye-sun (Adding Hongye who may have some input on this). @cliveseldon, would you be interested in contributing so that it is easy to specify the following in the DSL? https://github.com/argoproj/argo/tree/master/examples#docker-in-docker-using-sidecars |
@vicaire Happy to help. Just a bit new to the code base so not sure where to start. |
@cliveseldon, the docker in docker support depends on sidecar feature, which is currently working in the PR (#879). Once the PR is in, you should be able to build similar pipeline as argo example does. |
This #879 is merged. Feel free to add the docker-in-docker feature. |
I don't think there is more work need to be done to support dind other than the sidecar support. Closing this bug. |
* update set values tests * use variable name consistency
for testing, no persistent storage is needed. Use `emptyDir:{}` for minio and mysql Signed-off-by: Yihong Wang <yh.wang@ibm.com>
We would like to have steps in a pipeline that allow image builders. This might require docker-in-docker.
How can this be easily facilitated?
The text was updated successfully, but these errors were encountered: