-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ScheduledWorkflow CRD: CLI #7
Comments
It will be done in this repo. Thanks! |
@vicaire Already done to make CLI? If it has not started yet, I'll make it! |
Sure, could you make a proposal of how it will look like? It would be nice if it could take as a parameter a file with an Argo workflow, and automatically generate the yaml for the ScheduledWorkflow. |
@vicaire First, I'll make a command for installation of controller and CRD like |
That looks great! |
Why do we need a CLI to install the CRD? Why can't it just be installed as ksonnet package like all the other components in the registry? Using a CLI to install the controllers goes against the idea in K8s of managing infrastructure decoratively using config. I also don't think it would scale very well; e.g. having individual CLI's for every CRD in Kubeflow and forcing the user to install each one would be unwieldy. |
@jlewi First, I think CLI to manage scheduledworkflows should be prepared. For example, for dealing with the case to continue execution of the Argo workflow where it left off (or by indicating arbitrary position). I think it's troublesome to handle this by And also I don't think it's strange to install the components (CRD/controller) into k8s using this CLI owing to consistency of operations. But I agreed your opinions too. So I'll commit except for CLIs (I think there is no rush to prepare CLI itself) in #12 PR. |
For installation of the CRD, we indeed need to conform to the Kubeflow standard of using a ksonnet package. Thanks for the reminder @jlewi. |
I got it. Thanks. |
…les. (kubeflow#7) Revert "Merge pull request #2 from jlewi/py" This reverts commit 9273125, reversing changes made to b018ac6.
UPSTREAM: <carry>: add actions from dsp tekton repo.
Will it prepare the scheduledworkflows' CLIs in this repository to manage controller like
argo
? Or adding subcommands to argo.The text was updated successfully, but these errors were encountered: