-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remember the page I was on #62
Comments
To confirm, do you mean the page within the list? |
@rileyjbauer Yes As a side note: In the system I've used, the run list was a panel, so selecting a run did not remove the list from the screen. |
I'm afraid there's no good way of doing this if we can't get the page index from the backend. If we can, then we can add it to query parameters so that it's saved in the browser history stack. |
@IronPan if he thinks this is planned, otherwise let's close this issue. |
Closing as suggested by Yasser. |
I think this UX issue is still valid regardless of the implementation details. |
I think this is a valid ask. Temporary workaround: @Ark-kun do you think always opening a new page when clicking on runs would be better. User context in all runs page will be kept for them to come back. To properly design front-end to remember last state is a complex problem that requires more thorough design (I've done it once in my previous job, but I don't fully like the approach I took now because of extra code coupling it involved). |
AFAIK, usually the websites send the page and count as query parameters. This way each page has a distinct URL. |
It doesn't work with our backend, because we cannot query lists by page and count. We can only query by pageToken and count. Therefore, the state of a table is a list of pageToken that corresponding to each page user has already seen: code. That's not sth suitable for persisting in the URL. Unless we decide to let backend support that, frontend can only cache these info in memory to allow users later come back to a previous state in a table. |
I see. Thanks for the explanation. |
I want to think over a solution carefully. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
/lifecycle frozen |
Closing due to lack of interaction/follow up in more than 2 years. |
* Includes Data Plane Architecture Diagram * Includes a brief overview of data plane principles
* add initial pipelinerun support * update comment * rearrange compile function
chore: Update ODH Manifests README
feat: add artifact storage api for backend
In the All runs list, I click on a run, then use the browser's back button. This does not return me to the same page.
The text was updated successfully, but these errors were encountered: