Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember the page I was on #62

Closed
Ark-kun opened this issue Nov 5, 2018 · 14 comments
Closed

Remember the page I was on #62

Ark-kun opened this issue Nov 5, 2018 · 14 comments
Assignees

Comments

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 5, 2018

In the All runs list, I click on a run, then use the browser's back button. This does not return me to the same page.

@rileyjbauer
Copy link
Contributor

To confirm, do you mean the page within the list?

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 13, 2018

@rileyjbauer Yes

As a side note: In the system I've used, the run list was a panel, so selecting a run did not remove the list from the screen.

@yebrahim
Copy link
Contributor

I'm afraid there's no good way of doing this if we can't get the page index from the backend. If we can, then we can add it to query parameters so that it's saved in the browser history stack.

@yebrahim
Copy link
Contributor

@IronPan if he thinks this is planned, otherwise let's close this issue.

@vicaire
Copy link
Contributor

vicaire commented Mar 26, 2019

Closing as suggested by Yasser.

@vicaire vicaire closed this as completed Mar 26, 2019
@Ark-kun Ark-kun assigned jingzhang36 and unassigned Ark-kun Oct 4, 2019
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Oct 4, 2019

I think this UX issue is still valid regardless of the implementation details.

@Ark-kun Ark-kun reopened this Oct 4, 2019
@Bobgy Bobgy assigned Bobgy and unassigned jingzhang36 and yebrahim Oct 23, 2019
@Bobgy
Copy link
Contributor

Bobgy commented Oct 23, 2019

I think this is a valid ask.

Temporary workaround: @Ark-kun do you think always opening a new page when clicking on runs would be better. User context in all runs page will be kept for them to come back.
The user experience isn't as smooth as always using the same tab, but system complexity for our UI code is a lot simpler.

To properly design front-end to remember last state is a complex problem that requires more thorough design (I've done it once in my previous job, but I don't fully like the approach I took now because of extra code coupling it involved).
It easily adds a lot of complexity to the project, so I don't think I want to do this soon.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 2, 2019

AFAIK, usually the websites send the page and count as query parameters. This way each page has a distinct URL.

@Bobgy
Copy link
Contributor

Bobgy commented Nov 5, 2019

It doesn't work with our backend, because we cannot query lists by page and count. We can only query by pageToken and count. Therefore, the state of a table is a list of pageToken that corresponding to each page user has already seen: code.

That's not sth suitable for persisting in the URL.

Unless we decide to let backend support that, frontend can only cache these info in memory to allow users later come back to a previous state in a table.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 5, 2019

I see. Thanks for the explanation.

@Bobgy Bobgy added status/triaged Whether the issue has been explicitly triaged kind/feature labels Jan 22, 2020
@Bobgy
Copy link
Contributor

Bobgy commented Jan 22, 2020

I want to think over a solution carefully.

@stale
Copy link

stale bot commented Sep 20, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Sep 20, 2020
@Bobgy
Copy link
Contributor

Bobgy commented Sep 23, 2020

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen and removed lifecycle/stale The issue / pull request is stale, any activities remove this label. labels Sep 23, 2020
@chensun
Copy link
Member

chensun commented Jan 18, 2023

Closing due to lack of interaction/follow up in more than 2 years.

@chensun chensun closed this as completed Jan 18, 2023
Linchin pushed a commit to Linchin/pipelines that referenced this issue Apr 11, 2023
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
* Includes Data Plane Architecture Diagram

* Includes a brief overview of data plane principles
HumairAK referenced this issue in red-hat-data-services/data-science-pipelines Mar 11, 2024
* add initial pipelinerun support

* update comment

* rearrange compile function
HumairAK referenced this issue in red-hat-data-services/data-science-pipelines Mar 11, 2024
HumairAK added a commit to HumairAK/data-science-pipelines that referenced this issue Jul 17, 2024
feat: add artifact storage api for backend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants