Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in pipeline samples' parameters #478

Closed
nikhilsharma93 opened this issue Dec 5, 2018 · 4 comments
Closed

Bug in pipeline samples' parameters #478

nikhilsharma93 opened this issue Dec 5, 2018 · 4 comments
Assignees

Comments

@nikhilsharma93
Copy link

https://github.com/kubeflow/pipelines/blob/master/samples/basic/parallel_join.py#L25-L26 are not a dsl.PipelineParam as they should be

@gaoning777
Copy link
Contributor

This is one of the features we shipped recently. Users can specify the parameters directly(url='hello') instead of using PipelineParam class.
If it is not working for you, try the newest version SDK, please.

@nikhilsharma93
Copy link
Author

I upgraded my SDK (pip3 install https://storage.googleapis.com/ml-pipeline/release/0.1.2/kfp.tar.gz --upgrade), which is now at kfp-0.1

But I still get this error when I try to compile that file:

Traceback (most recent call last):
  File "/home/nikhil/.virtualenvs/python_3_5/venp35/bin/dsl-compile", line 11, in <module>
    sys.exit(main())
  File "/home/nikhil/.virtualenvs/python_3_5/venp35/lib/python3.5/site-packages/kfp/compiler/main.py", line 100, in main
    compile_pyfile(args.py, args.function, args.output)
  File "/home/nikhil/.virtualenvs/python_3_5/venp35/lib/python3.5/site-packages/kfp/compiler/main.py", line 89, in compile_pyfile
    _compile_pipeline_function(function_name, output_path)
  File "/home/nikhil/.virtualenvs/python_3_5/venp35/lib/python3.5/site-packages/kfp/compiler/main.py", line 69, in _compile_pipeline_function
    kfp.compiler.Compiler().compile(pipeline_func, output_path)
  File "/home/nikhil/.virtualenvs/python_3_5/venp35/lib/python3.5/site-packages/kfp/compiler/compiler.py", line 526, in compile
    workflow = self._compile(pipeline_func)
  File "/home/nikhil/.virtualenvs/python_3_5/venp35/lib/python3.5/site-packages/kfp/compiler/compiler.py", line 491, in _compile
    self._validate_args(argspec)
  File "/home/nikhil/.virtualenvs/python_3_5/venp35/lib/python3.5/site-packages/kfp/compiler/compiler.py", line 465, in _validate_args
    'Default values of argument has to be type dsl.PipelineParam or its child.')
ValueError: Default values of argument has to be type dsl.PipelineParam or its child.

@gaoning777
Copy link
Contributor

gaoning777 commented Dec 5, 2018

Could you try the newest version: pip3 install https://storage.googleapis.com/ml-pipeline/release/0.1.3-rc.3/kfp.tar.gz --upgrade. 0.1.2 is released a month ago without the new feature. 0.1.3-rc.3 works at my end.

@nikhilsharma93
Copy link
Author

Yes, that works. Thank you

@gaoning777 gaoning777 self-assigned this Dec 5, 2018
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this issue Mar 11, 2024
…inable CEL Custom task (kubeflow#478)

* add cel custom task poc

* apply suggestions with minor fixes

* add initial version of plugable cel template

* fix lint

* update staging code for converting containerOp to custom task

* update staging code for converting containerOp to custom task

* remove duplicate cel conditions

* update flip-coin example to use custom task

* update flip-coin example to use custom task

* remove dsl dependencies;

* add POC comments

* fix lint

* fix self-defined CEL custom task mapping

* move custom task condition example to a separate folder

* fix tests

* make the new custom task spec and CEL condition feature as opt-in

* update instructions and generalize custom task images

* only let custom task result comparasion to skip the condition container to provide backward compatibility

* only let custom task result comparasion to skip the condition container to provide backward compatibility

* update example

* update tests

* fix comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants