Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone deployment is not using the proxy in the correct region #4284

Closed
numerology opened this issue Jul 29, 2020 · 8 comments · Fixed by #4702
Closed

Standalone deployment is not using the proxy in the correct region #4284

numerology opened this issue Jul 29, 2020 · 8 comments · Fixed by #4702

Comments

@numerology
Copy link

If a standalone deployment is deployed to a us-central1 GKE cluster, it is supposed to talk to inverse proxy us-central1. However currently it seems like it's talking to us-central2, which is inconsistent with our proxy config.

@numerology
Copy link
Author

/assign @rmgogogo
/assign @numerology

/cc @abdallag

@stale
Copy link

stale bot commented Oct 28, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Oct 28, 2020
@Bobgy
Copy link
Contributor

Bobgy commented Oct 28, 2020

@numerology can you provide more details?

Choosing which proxy is code we maintain in KFP, so one of us need to investigate this.

@stale stale bot removed the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Oct 28, 2020
@numerology
Copy link
Author

/lifecycle frozen

@numerology
Copy link
Author

@Bobgy Sorry I dropped the ball on this one...

For example, if a user deploys KFP onto a GKE cluster in us-central1 region, then according to this config inverse proxy should return a host name suffixed by us-central1, but it's currently xxx-us-central2. It's not blocking usage but suboptimal.

@Bobgy
Copy link
Contributor

Bobgy commented Oct 29, 2020

Understood, FYI code for deciding which proxy url to choose is in https://github.com/kubeflow/pipelines/blob/0ff6d9cfa438119785b94b8802f4bf7d36f95bda/proxy/get_proxy_url.py, so anyone who'll try to fix this problem should troubleshoot there.

suryaavala added a commit to suryaavala/pipelines that referenced this issue Nov 1, 2020
uses proxy url that is closest to the given zone

Fixes kubeflow#4284
@suryaavala
Copy link
Contributor

@Bobgy I submitted a fix in #4702, would you be able to review it?

k8s-ci-robot pushed a commit that referenced this issue Nov 1, 2020
* fix: fixes proxy url priority

uses proxy url that is closest to the given zone

Fixes #4284

* style: formatting proxy with yapf

using .style.yapf provided in the repo
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this issue Dec 9, 2020
…kubeflow#4702)

* fix: fixes proxy url priority

uses proxy url that is closest to the given zone

Fixes kubeflow#4284

* style: formatting proxy with yapf

using .style.yapf provided in the repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment