-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standalone deployment is not using the proxy in the correct region #4284
Comments
/assign @rmgogogo /cc @abdallag |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@numerology can you provide more details? Choosing which proxy is code we maintain in KFP, so one of us need to investigate this. |
/lifecycle frozen |
@Bobgy Sorry I dropped the ball on this one... For example, if a user deploys KFP onto a GKE cluster in us-central1 region, then according to this config inverse proxy should return a host name suffixed by |
Understood, FYI code for deciding which proxy url to choose is in https://github.com/kubeflow/pipelines/blob/0ff6d9cfa438119785b94b8802f4bf7d36f95bda/proxy/get_proxy_url.py, so anyone who'll try to fix this problem should troubleshoot there. |
uses proxy url that is closest to the given zone Fixes kubeflow#4284
…kubeflow#4702) * fix: fixes proxy url priority uses proxy url that is closest to the given zone Fixes kubeflow#4284 * style: formatting proxy with yapf using .style.yapf provided in the repo
If a standalone deployment is deployed to a us-central1 GKE cluster, it is supposed to talk to inverse proxy us-central1. However currently it seems like it's talking to us-central2, which is inconsistent with our proxy config.
The text was updated successfully, but these errors were encountered: