Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No information in error message when visualization server is not accessible #4157

Closed
Bobgy opened this issue Jul 7, 2020 · 2 comments · Fixed by #4201
Closed

No information in error message when visualization server is not accessible #4157

Bobgy opened this issue Jul 7, 2020 · 2 comments · Fixed by #4201
Assignees
@PatrickXYS
Labels
area/backend good first issue status/triaged Whether the issue has been explicitly triaged

Comments

@Bobgy
Copy link
Contributor

Bobgy commented Jul 7, 2020

pipelines/backend/src/apiserver/server/visualization_server.go

Line 82 in bd0f4d2

return nil, util.NewInternalServerError(

When visualization server is not responding, error message in api server is not helpful at all. It should show upstream error message to help troubleshooting.
@Bobgy Bobgy added area/backend status/triaged Whether the issue has been explicitly triaged good first issue labels Jul 7, 2020
@Bobgy
Copy link
Contributor Author

Bobgy commented Jul 7, 2020

Hi @PatrickXYS, I think this is a good first issue you can look at.

FYI, you can find backend develop instructions in https://github.com/kubeflow/pipelines/tree/master/backend.
Feel free to ask any questions

@PatrickXYS
Copy link
Member

@Bobgy Thanks a lot! Will keep you updated about any progress

@PatrickXYS PatrickXYS mentioned this issue Jul 12, 2020
Merged
2 tasks
k8s-ci-robot pushed a commit that referenced this issue Jul 17, 2020
@PatrickXYS
fix(backend): fixes useless error message when visualization-server i…
d3d4dcb 
…s not accessible. Fixes #4157 (#4201)

Add another unit test to handle ServiceHostNotExistError
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this issue Dec 9, 2020
@PatrickXYS @Jeffwan
fix(backend): fixes useless error message when visualization-server i…
7a4990a 
…s not accessible. Fixes kubeflow#4157 (kubeflow#4201)

Add another unit test to handle ServiceHostNotExistError
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PatrickXYS PatrickXYS

Labels
area/backend good first issue status/triaged Whether the issue has been explicitly triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(backend): fixes useless error message when visualization-server is not accessible. Fixes #4157
2 participants
@Bobgy @PatrickXYS