Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Names of file inputs with raw arguments are not properly sanitized by the compiler #4110

Closed
Ark-kun opened this issue Jun 29, 2020 · 0 comments · Fixed by #4120
Closed

Names of file inputs with raw arguments are not properly sanitized by the compiler #4110

Ark-kun opened this issue Jun 29, 2020 · 0 comments · Fixed by #4120
Assignees
Labels
area/sdk/dsl/compiler area/sdk kind/bug status/triaged Whether the issue has been explicitly triaged

Comments

@Ark-kun
Copy link
Contributor

Ark-kun commented Jun 29, 2020

When passing output references to inputs consumed as files, everything works fine.
When passing constant strings to inputs consumed as files, the artifact names are not sanitized leading to invalid workflows.

templates:
    - inputs:
      parameters:
      - {name: model_dir_uri}
      artifacts:
      - raw: {data: ''}
        path: /tmp/inputs/Default_data/data
        name: Default data
invalid spec: templates.continuous-training-pipeline.tasks.download-from-gcs templates.download-from-gcs.inputs.artifacts[0].name: 'Default data' is invalid: Parameter/Artifact name must consist of alpha-numeric characters, '_' or '-' e.g. my_param_1, MY-PARAM-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sdk/dsl/compiler area/sdk kind/bug status/triaged Whether the issue has been explicitly triaged
Projects
None yet
1 participant