Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compilation should fail when user passes the whole task instead of one output to an input #4040

Closed
Ark-kun opened this issue Jun 21, 2020 · 1 comment · Fixed by #4496
Closed

Compilation should fail when user passes the whole task instead of one output to an input #4040

Ark-kun opened this issue Jun 21, 2020 · 1 comment · Fixed by #4496
Assignees
@Ark-kun
Labels
area/sdk kind/bug status/triaged Whether the issue has been explicitly triaged

Comments

@Ark-kun
Copy link
Contributor

Ark-kun commented Jun 21, 2020 •
edited
Loading

Example broken code which should fail:

my_task1 = my_op1()
my_op2(my_task1)

The correct code:

my_task1 = my_op1()
my_op2(my_task1.output)

Currently the ContainerOp is silently converted to a big string constant and passed downstream which also triggers problems with data passing.
@Ark-kun Ark-kun self-assigned this Jun 21, 2020
@Bobgy Bobgy added the status/triaged Whether the issue has been explicitly triaged label Jun 22, 2020
@PatrickXYS
Copy link
Member

Looking to see if I can help

@Ark-kun Ark-kun mentioned this issue Jul 18, 2020
Closed
@Ark-kun Ark-kun mentioned this issue Sep 14, 2020
Merged
k8s-ci-robot pushed a commit that referenced this issue Sep 16, 2020
@Ark-kun
feat(sdk): Components - Prevent passing unserializable objects to com…
0332584 
…ponents. Fixes #4040 (#4496)
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this issue Dec 9, 2020
@Ark-kun @Jeffwan
feat(sdk): Components - Prevent passing unserializable objects to com…
c902e93 
…ponents. Fixes kubeflow#4040 (kubeflow#4496)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ark-kun Ark-kun

Labels
area/sdk kind/bug status/triaged Whether the issue has been explicitly triaged
Projects
None yet
Milestone
No milestone
3 participants
@Ark-kun @Bobgy @PatrickXYS