-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dsl.graph_component does not honor named arguments, resulting wrong params #3915
Comments
Thank you for your patience. I somehow missed this issue. (@rmgogogo Please feel free to assign most SDK-related issues to me, especially component-related.) P.S. JFYI: The |
…graph_component. Fixes kubeflow#3915 (4082) * SDK - Compiler - Fixed the input argument mapping when using dsl.graph_component Fixes kubeflow#3915 * Stopped relying on the argument order at all This can make the compilation less fragile.
…graph_component. Fixes kubeflow#3915 (4082) * SDK - Compiler - Fixed the input argument mapping when using dsl.graph_component Fixes kubeflow#3915 * Stopped relying on the argument order at all This can make the compilation less fragile.
…graph_component. Fixes kubeflow#3915 (4082) * SDK - Compiler - Fixed the input argument mapping when using dsl.graph_component Fixes kubeflow#3915 * Stopped relying on the argument order at all This can make the compilation less fragile.
What steps did you take:
The code below results in correct recursive call, "count" and "limit" gets the correct arguments. However, by switching the order of "count" and "limit", the 2nd call to increment_component has the wrong arguments.
-----------this works-----------------
-----------its YAML------------------
-----------this does NOT works-----------------
-----------its YAML------------------
What did you expect to happen:
KFP compiler should honor named arguments.
Environment:
https://storage.googleapis.com/ml-pipeline/release/0.5.1/kfp.tar.gz
The text was updated successfully, but these errors were encountered: