Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload Pipeline Version If already exists #3901

Closed
talhairfanbentley opened this issue Jun 3, 2020 · 5 comments
Closed

Upload Pipeline Version If already exists #3901

talhairfanbentley opened this issue Jun 3, 2020 · 5 comments
Assignees
@NikeNano
Labels
area/sdk/client kind/question status/triaged Whether the issue has been explicitly triaged

Comments

@talhairfanbentley
Copy link

It's not a bug or issue.
In case it doesn't exists, then it's a suggestion

Is there any way I can upload pipeline to kubeflow via sdk, and it just uploads a version if the main pipeline already exists.

Versions:

kfp                      0.4.0
kfp-server-api           0.3.0
@rmgogogo
Copy link
Contributor

rmgogogo commented Jun 5, 2020

I think it's already supported. Do you mean only-upload/insert versions if there is already a pipeline there? Please update the KFP version for a retry.

@jingzhang36

@rmgogogo rmgogogo added kind/question status/triaged Whether the issue has been explicitly triaged labels Jun 5, 2020
@talhairfanbentley
Copy link
Author

No, I mean. I shouldn't need to get pipeline ID before uploading a version.
As of now, the flow is.

If Pipeline Exists > Get Pipeline ID > Upload Pipeline Version
If Pipeline Does not exists > Upload Pipeline

@talhairfanbentley
Copy link
Author

Just a little update, I have update versions, but there's no change of sort that I was looking for.

kfp                      0.5.1              
kfp-server-api           0.5.0

@dilip640
Copy link

dilip640 commented Jun 9, 2020

Thank you @talhairfanbentley for raising this issue, I was also looking for the same feature. It should ask the name and version of the pipeline. If the pipeline name exists then upload as version otherwise upload as a new pipeline.

@NikeNano
Copy link
Member

I will work on a PR for this.
/assign

@NikeNano NikeNano mentioned this issue Jun 26, 2020
Merged
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this issue Dec 9, 2020
@Jeffwan
feat(sdk): CLI - Allow upload_version by the pipeline's name. Fixes k…
662af04 
…ubeflow#3901 (kubeflow#4087)

* Update _client.py

* Allow for passing name instead of only pipeline_id

* fixed old rebase issue

* protobuf fix

* raise error and remove f-string

* moved file

* updated python proto packages versions

* Update sdk/python/kfp/_client.py

* restructured and added to build

* changes structure of import

* Updated the files

* further updates of client and filter.proto

* alternative

* clean up

* clean up

* remove helperfiles

* futher clean up

* clean up or eaither name or id

* update doc strings

* remove page_size

* Update sdk/python/kfp/_client.py

Co-authored-by: Jiaxiao Zheng <jxzheng@google.com>

* Update sdk/python/kfp/cli/pipeline.py

Co-authored-by: Jiaxiao Zheng <jxzheng@google.com>

* updated to classical string formattin

Co-authored-by: Jiaxiao Zheng <jxzheng@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NikeNano NikeNano

Labels
area/sdk/client kind/question status/triaged Whether the issue has been explicitly triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rmgogogo @Bobgy @NikeNano @dilip640 @talhairfanbentley