Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FR: support Argo Pod Disruption Budget #3877

Closed
frozeNinK opened this issue May 29, 2020 · 1 comment
Closed

FR: support Argo Pod Disruption Budget #3877

frozeNinK opened this issue May 29, 2020 · 1 comment
Assignees
@NikeNano
Labels
help wanted The community is welcome to contribute. kind/feature priority/p2 status/triaged Whether the issue has been explicitly triaged

Comments

@frozeNinK
Copy link
Contributor

frozeNinK commented May 29, 2020 •
edited
Loading

What steps did you take:

Add support to PDB provided by Argo / K8s
ref:

What happened:

This is to prevent / decrease the frequency a pod is killed by k8s due to auto scaling
@rmgogogo rmgogogo changed the title Feature request FR: support Argo Pod Disruption Budget Jun 4, 2020
@rmgogogo rmgogogo added kind/feature status/triaged Whether the issue has been explicitly triaged help wanted The community is welcome to contribute. priority/p2 labels Jun 4, 2020
@NikeNano
Copy link
Member

NikeNano commented Jul 8, 2020

/assign

@NikeNano NikeNano mentioned this issue Jul 8, 2020
Merged
2 tasks
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this issue Dec 9, 2020
@Jeffwan
feat(compiled): set pod disruption budget for pipelines. Fixes kubefl…
59d961f 
…ow#3877 (kubeflow#4178)

* Update _client.py

* Update _client.py

* added pod disruption budget

* clean up

* Update sdk/python/kfp/dsl/_pipeline.py

* fixed parameter

* updated after feedback

* removed selector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NikeNano NikeNano

Labels
help wanted The community is welcome to contribute. kind/feature priority/p2 status/triaged Whether the issue has been explicitly triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rmgogogo @NikeNano @frozeNinK