-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Presubmit tests are broken since we rely on pulling node.js image that was removed #370
Comments
Node 9 was dropped in June: The schedule was announced couple of years ago: nodejs/Release@a058d35#diff-c5a445b5d198a13d8c4b4a82af5f2929R44 We might want to us LTS releases that have longer support. |
Thanks for bringing this up, yes we need the upgrade. |
https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/kubeflow_pipelines/315/build-image/573/ and multiple other tests runs. Looks like that might have been a DockerHub or proxy issue that lasted some hours.
Hmm. Strange. |
It's likely it'll be kept around for a while to avoid breaking active projects (I can still pull node 7 alpine too), but we should update the dependency to lts. |
Can we rename this issue to track this update, since we're not really breaking presubmits? |
Looks like the issue was caused by temporary DockerHub problems when it started returning 4040 errors for many images. |
node:9.4.0-alpine no longer exists. Unfortunately we're still pulling it every time instead of relying on a static base image.
The text was updated successfully, but these errors were encountered: