Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presubmit tests are broken since we rely on pulling node.js image that was removed #370

Closed
Ark-kun opened this issue Nov 26, 2018 · 6 comments
Assignees

Comments

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 26, 2018

node:9.4.0-alpine no longer exists. Unfortunately we're still pulling it every time instead of relying on a static base image.

build-frontend-image:	Step 12/20 : FROM node:9.4.0-alpine
build-frontend-image:	9.4.0-alpine: Pulling from library/node
build-frontend-image:	error parsing HTTP 404 response body: invalid character 'p' after top-level value: "404 page not found\n"
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 26, 2018

Node 9 was dropped in June:
https://github.com/nodejs/Release/blob/bc9d936e153b9fafd7f7c203f139d02035ca6862/schedule.json#L44
nodejs/docker-node#803

The schedule was announced couple of years ago: nodejs/Release@a058d35#diff-c5a445b5d198a13d8c4b4a82af5f2929R44

We might want to us LTS releases that have longer support.

@yebrahim
Copy link
Contributor

Thanks for bringing this up, yes we need the upgrade.
I don't see this blocking tests anywhere though, and pulling node:9.4.0-alpine still works. Where did you see presubmit tests failing with this error?

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 26, 2018

Where did you see presubmit tests failing with this error?

https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/kubeflow_pipelines/315/build-image/573/ and multiple other tests runs. Looks like that might have been a DockerHub or proxy issue that lasted some hours.

pulling node:9.4.0-alpine still works

Hmm. Strange.
I do not see any 9 in https://hub.docker.com/r/library/node/ or https://hub.docker.com/r/library/node/tags/

@yebrahim
Copy link
Contributor

It's likely it'll be kept around for a while to avoid breaking active projects (I can still pull node 7 alpine too), but we should update the dependency to lts.

@yebrahim
Copy link
Contributor

Can we rename this issue to track this update, since we're not really breaking presubmits?

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Dec 4, 2018

Looks like the issue was caused by temporary DockerHub problems when it started returning 4040 errors for many images.

@Ark-kun Ark-kun closed this as completed Dec 4, 2018
Linchin pushed a commit to Linchin/pipelines that referenced this issue Apr 11, 2023
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this issue Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants