Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Our tests clone our repo 40+ times for each PR commit (and some PRs have dozens of commits) #368

Closed
Ark-kun opened this issue Nov 23, 2018 · 0 comments

Comments

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 23, 2018

And the real number is much higher due to test failures and re-runs.

Prow pulls our repo for each test suite (we have 5+).
Our test workflows pull the code to build images (24 times). Most of those come from sample tests.
Our test runners then pull the code again before running (11 times). For some reason we only put a single run_test.sh script in test images and not all the required code.

build_image.yaml: build-bootstrapper-image
build_image.yaml: build-api-server-image
build_image.yaml: build-frontend-image
build_image.yaml: build-scheduledworkflow-image
build_image.yaml: build-persistenceagent-image
e2e_test_gke.yaml: build-api-integration-test-image
e2e_test_gke.yaml: build-frontend-integration-tests-image
e2e_test_gke.yaml: build-basic-e2e-tests-image
e2e_test_gke.yaml: run-api-integration-tests
e2e_test_gke.yaml: run-frontend-integration-tests
e2e_test_gke.yaml: run-condition-tests
e2e_test_gke.yaml: run-exit-handler-tests
e2e_test_gke.yaml: run-sequential-tests
e2e_test_gke.yaml: run-immediate-value-tests
e2e_test_gke.yaml: run-parallel-join-tests
sample_test.yaml: build-sample-tests-image
sample_test.yaml: build-dataflow-tft-image
sample_test.yaml: build-dataflow-predict-image
sample_test.yaml: build-dataflow-tfma-image
sample_test.yaml: build-dataflow-tfdv-image
sample_test.yaml: build-dataproc-create-cluster-image
sample_test.yaml: build-dataproc-delete-cluster-image
sample_test.yaml: build-dataproc-analyze-image
sample_test.yaml: build-dataproc-transform-image
sample_test.yaml: build-dataproc-train-image
sample_test.yaml: build-dataproc-predict-image
sample_test.yaml: build-kubeflow-dnntrainer-image
sample_test.yaml: build-kubeflow-deployer-image
sample_test.yaml: build-local-confusion-matrix
sample_test.yaml: build-local-roc
sample_test.yaml: run-tf-training-tests
sample_test.yaml: run-tfx-tests
sample_test.yaml: run-xgboost-tests
unit_test_gke.yaml: build-backend-unit-tests-image
unit_test_gke.yaml: run-backend-unit-tests
grep -E 'name: (build-|run-)' *.yaml | grep -Ev 'build-images?|build-script' | grep -Ev ':  -' | sed -E 's/    ( |-) - name://g'
@Ark-kun Ark-kun changed the title Our test pull our repo 40+ times for each PR commit (and some PRs have dozens of commits) Our tests clone our repo 40+ times for each PR commit (and some PRs have dozens of commits) Nov 23, 2018
@vicaire vicaire assigned Ark-kun and unassigned vicaire Nov 26, 2018
@Ark-kun Ark-kun closed this as completed Nov 26, 2018
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants