Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backend should not rely on presence of samples. #355

Closed
Ark-kun opened this issue Nov 21, 2018 · 1 comment
Closed

Backend should not rely on presence of samples. #355

Ark-kun opened this issue Nov 21, 2018 · 1 comment

Comments

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 21, 2018

In #110 the bootstrapper silently fails to start the backend due to missing samples.

Missing samples should not be fatal. https://github.com/kubeflow/pipelines/blob/master/backend/src/apiserver/main.go#L57

My opinion is that the backend should not know about samples at all. The samples should be injected in the cluster instance by the bootstrapper.
@vicaire vicaire removed their assignment Nov 26, 2018
@vicaire
Copy link
Contributor

vicaire commented Mar 26, 2019

Resolving in favor of #455

@vicaire vicaire closed this as completed Mar 26, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
@yuzisun @k8s-ci-robot
Add text explainer notebook (kubeflow#355)
4c647d9 
* Add text explainer notebook example

* Fix formatting
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this issue Mar 11, 2024
@animeshsingh
restructure installation and user instructions (kubeflow#355)
f60887d 
* reconcile .md files in one single place

* add guides folder

* update install links

* update install links

* add all guides
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Ark-kun @IronPan @vicaire