Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backend image build does not fail when sample compilation fails #354

Closed
Ark-kun opened this issue Nov 21, 2018 · 0 comments
Closed

Backend image build does not fail when sample compilation fails #354

Ark-kun opened this issue Nov 21, 2018 · 0 comments
Assignees
@IronPan @gaoning777 @qimingj
Labels
area/backend priority/p0

Comments

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 21, 2018 •
edited
Loading

In #110 the samples failed to compile, but it did not stop the backend image from being generated.

https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/kubeflow_pipelines/110/build-image/148/build-log.txt

[37mbuild-api-server-image�[0m:	Step 14/25 : RUN  find . -maxdepth 2 -name "*.py" -exec dsl-compile --py {} --output {}.tar.gz \;
�[37mbuild-api-server-image�[0m:	 ---> Running in a78ef0ed9d18
�[37mbuild-api-server-image�[0m:	�[91mTraceback (most recent call last):
�[37mbuild-api-server-image�[0m:	  File "/usr/local/bin/dsl-compile", line 11, in <module>
�[37mbuild-api-server-image�[0m:	    load_entry_point('\''kfp==0.1'\'', '\''console_scripts'\'', '\''dsl-compile'\'')()
�[37mbuild-api-server-image�[0m:	  File "/usr/local/lib/python3.5/site-packages/kfp/compiler/main.py", line 100, in main
�[37mbuild-api-server-image�[0m:	    compile_pyfile(args.py, args.function, args.output)
�[37mbuild-api-server-image�[0m:	  File "/usr/local/lib/python3.5/site-packages/kfp/compiler/main.py", line 89, in compile_pyfile
�[37mbuild-api-server-image�[0m:	    _compile_pipeline_function(function_name, output_path)
�[37mbuild-api-server-image�[0m:	  File "/usr/local/lib/python3.5/site-packages/kfp/compiler/main.py", line 69, in _compile_pipeline_function
�[37mbuild-api-server-image�[0m:	    kfp.compiler.Compiler().compile(pipeline_func, output_path)
�[37mbuild-api-server-image�[0m:	  File "/usr/local/lib/python3.5/site-packages/kfp/compiler/compiler.py", line 526, in compile
�[37mbuild-api-server-image�[0m:	    workflow = self._compile(pipeline_func)
�[37mbuild-api-server-image�[0m:	  File "/usr/local/lib/python3.5/site-packages/kfp/compiler/compiler.py", line 491, in _compile
�[37mbuild-api-server-image�[0m:	    self._validate_args(argspec)
�[37mbuild-api-server-image�[0m:	  File "/usr/local/lib/python3.5/site-packages/kfp/compiler/compiler.py", line 465, in _validate_args
�[37mbuild-api-server-image�[0m:	    '\''Default values of argument has to be type dsl.PipelineParam or its child.'\'')
�[37mbuild-api-server-image�[0m:	ValueError: Default values of argument has to be type dsl.PipelineParam or its child.
�[37mbuild-api-server-image�[0m:	�[0m�[91mTraceback (most recent call last):
�[37mbuild-api-server-image�[0m:	  File "/usr/local/bin/dsl-compile", line 11, in <module>
�[37mbuild-api-server-image�[0m:	    load_entry_point('\''kfp==0.1'\'', '\''console_scripts'\'', '\''dsl-compile'\'')()
�[37mbuild-api-server-image�[0m:	  File "/usr/local/lib/python3.5/site-packages/kfp/compiler/main.py", line 100, in main
�[37mbuild-api-server-image�[0m:	    compile_pyfile(args.py, args.function, args.output)
�[37mbuild-api-server-image�[0m:	  File "/usr/local/lib/python3.5/site-packages/kfp/compiler/main.py", line 89, in compile_pyfile
�[37mbuild-api-server-image�[0m:	    _compile_pipeline_function(function_name, output_path)
�[37mbuild-api-server-image�[0m:	  File "/usr/local/lib/python3.5/site-packages/kfp/compiler/main.py", line 69, in _compile_pipeline_function
�[37mbuild-api-server-image�[0m:	    kfp.compiler.Compiler().compile(pipeline_func, output_path)
�[37mbuild-api-server-image�[0m:	  File "/usr/local/lib/python3.5/site-packages/kfp/compiler/compiler.py", line 526, in compile
�[37mbuild-api-server-image�[0m:	    workflow = self._compile(pipeline_func)
�[37mbuild-api-server-image�[0m:	  File "/usr/local/lib/python3.5/site-packages/kfp/compiler/compiler.py", line 491, in _compile
�[37mbuild-api-server-image�[0m:	    self._validate_args(argspec)
�[37mbuild-api-server-image�[0m:	  File "/usr/local/lib/python3.5/site-packages/kfp/compiler/compiler.py", line 465, in _validate_args
�[37mbuild-api-server-image�[0m:	    '\''Default values of argument has to be type dsl.PipelineParam or its child.'\'')
�[37mbuild-api-server-image�[0m:	ValueError: Default values of argument has to be type dsl.PipelineParam or its child.
�[37mbuild-api-server-image�[0m:	�[0m�[91mTraceback (most recent call last):
�[37mbuild-api-server-image�[0m:	  File "/usr/local/bin/dsl-compile", line 11, in <module>
�[37mbuild-api-server-image�[0m:	    load_entry_point('\''kfp==0.1'\'', '\''console_scripts'\'', '\''dsl-compile'\'')()
�[37mbuild-api-server-image�[0m:	  File "/usr/local/lib/python3.5/site-packages/kfp/compiler/main.py", line 100, in main
�[37mbuild-api-server-image�[0m:	    compile_pyfile(args.py, args.function, args.output)
�[37mbuild-api-server-image�[0m:	  File "/usr/local/lib/python3.5/site-packages/kfp/compiler/main.py", line 89, in compile_pyfile
�[37mbuild-api-server-image�[0m:	    _compile_pipeline_function(function_name, output_path)
�[37mbuild-api-server-image�[0m:	  File "/usr/local/lib/python3.5/site-packages/kfp/compiler/main.py", line 69, in _compile_pipeline_function
�[37mbuild-api-server-image�[0m:	    kfp.compiler.Compiler().compile(pipeline_func, output_path)
�[37mbuild-api-server-image�[0m:	  File "/usr/local/lib/python3.5/site-packages/kfp/compiler/compiler.py", line 526, in compile
�[37mbuild-api-server-image�[0m:	    workflow = self._compile(pipeline_func)
�[37mbuild-api-server-image�[0m:	  File "/usr/local/lib/python3.5/site-packages/kfp/compiler/compiler.py", line 491, in _compile
�[37mbuild-api-server-image�[0m:	    self._validate_args(argspec)
�[37mbuild-api-server-image�[0m:	  File "/usr/local/lib/python3.5/site-packages/kfp/compiler/compiler.py", line 465, in _validate_args
�[37mbuild-api-server-image�[0m:	    '\''Default values of argument has to be type dsl.PipelineParam or its child.'\'')
�[37mbuild-api-server-image�[0m:	ValueError: Default values of argument has to be type dsl.PipelineParam or its child.
�[37mbuild-api-server-image�[0m:	�[0m�[91mTraceback (most recent call last):
�[37mbuild-api-server-image�[0m:	  File "/usr/local/bin/dsl-compile", line 11, in <module>
�[37mbuild-api-server-image�[0m:	    load_entry_point('\''kfp==0.1'\'', '\''console_scripts'\'', '\''dsl-compile'\'')()
�[37mbuild-api-server-image�[0m:	  File "/usr/local/lib/python3.5/site-packages/kfp/compiler/main.py", line 100, in main
�[37mbuild-api-server-image�[0m:	    compile_pyfile(args.py, args.function, args.output)
�[37mbuild-api-server-image�[0m:	  File "/usr/local/lib/python3.5/site-packages/kfp/compiler/main.py", line 89, in compile_pyfile
�[37mbuild-api-server-image�[0m:	    _compile_pipeline_function(function_name, output_path)
�[37mbuild-api-server-image�[0m:	  File "/usr/local/lib/python3.5/site-packages/kfp/compiler/main.py", line 69, in _compile_pipeline_function
�[37mbuild-api-server-image�[0m:	    kfp.compiler.Compiler().compile(pipeline_func, output_path)
�[37mbuild-api-server-image�[0m:	  File "/usr/local/lib/python3.5/site-packages/kfp/compiler/compiler.py", line 526, in compile
�[37mbuild-api-server-image�[0m:	    workflow = self._compile(pipeline_func)
�[37mbuild-api-server-image�[0m:	  File "/usr/local/lib/python3.5/site-packages/kfp/compiler/compiler.py", line 491, in _compile
�[37mbuild-api-server-image�[0m:	    self._validate_args(argspec)
�[37mbuild-api-server-image�[0m:	  File "/usr/local/lib/python3.5/site-packages/kfp/compiler/compiler.py", line 465, in _validate_args
�[37mbuild-api-server-image�[0m:	    '\''Default values of argument has to be type dsl.PipelineParam or its child.'\'')
�[37mbuild-api-server-image�[0m:	ValueError: Default values of argument has to be type dsl.PipelineParam or its child.
�[37mbuild-api-server-image�[0m:	�[0m�[91mTraceback (most recent call last):
�[37mbuild-api-server-image�[0m:	  File "/usr/local/bin/dsl-compile", line 11, in <module>
�[37mbuild-api-server-image�[0m:	    load_entry_point('\''kfp==0.1'\'', '\''console_scripts'\'', '\''dsl-compile'\'')()
�[37mbuild-api-server-image�[0m:	  File "/usr/local/lib/python3.5/site-packages/kfp/compiler/main.py", line 100, in main
�[37mbuild-api-server-image�[0m:	    compile_pyfile(args.py, args.function, args.output)
�[37mbuild-api-server-image�[0m:	  File "/usr/local/lib/python3.5/site-packages/kfp/compiler/main.py", line 89, in compile_pyfile
�[37mbuild-api-server-image�[0m:	    _compile_pipeline_function(function_name, output_path)
�[37mbuild-api-server-image�[0m:	  File "/usr/local/lib/python3.5/site-packages/kfp/compiler/main.py", line 69, in _compile_pipeline_function
�[37mbuild-api-server-image�[0m:	    kfp.compiler.Compiler().compile(pipeline_func, output_path)
�[37mbuild-api-server-image�[0m:	  File "/usr/local/lib/python3.5/site-packages/kfp/compiler/compiler.py", line 526, in compile
�[37mbuild-api-server-image�[0m:	    workflow = self._compile(pipeline_func)
�[37mbuild-api-server-image�[0m:	  File "/usr/local/lib/python3.5/site-packages/kfp/compiler/compiler.py", line 491, in _compile
�[37mbuild-api-server-image�[0m:	    self._validate_args(argspec)
�[37mbuild-api-server-image�[0m:	  File "/usr/local/lib/python3.5/site-packages/kfp/compiler/compiler.py", line 465, in _validate_args
�[37mbuild-api-server-image�[0m:	    '\''Default values of argument has to be type dsl.PipelineParam or its child.'\'')
�[37mbuild-api-server-image�[0m:	ValueError: Default values of argument has to be type dsl.PipelineParam or its child.
�[37mbuild-api-server-image�[0m:	�[0m ---> a5f75b629016
@Ark-kun Ark-kun changed the title Bootstrapper build does not fail when sample compilation fails. Backend image build does not fail when sample compilation fails Nov 27, 2018
@Ark-kun Ark-kun mentioned this issue Nov 27, 2018
Merged
Linchin pushed a commit to Linchin/pipelines that referenced this issue Apr 11, 2023
@gabrielwen @k8s-ci-robot
get_kf_testing_cluster (kubeflow#354)
5c78690 
* bootstrap list

* use deploymentmanager

* init get_deployment

* finish functions

* doc

* pylint

* pylint

* pylint

* test init

* add readme as how to generate api json

* finish first test

* tests

* finish tests

* finish tests

* sort in list_deployment

* fix tests

* add get_latest_credential

* get resources in list

* fix tests

* add subparser

* make it CLI

* fix lint

* add field as args
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
@yuzisun @animeshsingh @k8s-ci-robot
Add transformer example (kubeflow#354)
a309954 
* image transformer example

* update readme

* update notebook

* Fix test

* add example input

* Fix examples

* add original pytorch link

* Fix output

* Update docs

Co-Authored-By: Animesh Singh <singhan@us.ibm.com>

* Update docs

Co-Authored-By: Animesh Singh <singhan@us.ibm.com>

* Apply suggestions from Animesh

Co-Authored-By: Animesh Singh <singhan@us.ibm.com>
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this issue Mar 11, 2024
@Tomcli
fix(sdk): Address default pipeline timeout behavior (kubeflow#354)
f3b315f 
* address timeout bug

* update default timeout behavior

* add flag to use tekton global default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IronPan IronPan

@gaoning777 gaoning777

@qimingj qimingj

Labels
area/backend priority/p0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Ark-kun @IronPan @gaoning777 @qimingj