Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add an optional name for dsl.Condition #3210

Closed
xiaohanhuang opened this issue Mar 3, 2020 · 2 comments
Closed

add an optional name for dsl.Condition #3210

xiaohanhuang opened this issue Mar 3, 2020 · 2 comments
Assignees
@Ark-kun @numerology @hongye-sun
Labels
area/sdk/dsl kind/feature status/triaged Whether the issue has been explicitly triaged

Comments

@xiaohanhuang
Copy link
Contributor

In the pipeline graph, condition-1, condition-2 etc are not informative. Allow a name param in the constructor would be helpful.
xiaohanhuang pushed a commit to xiaohanhuang/pipelines that referenced this issue Mar 4, 2020
add an optional name for dsl.Condition (kubeflow#3210)
244b690
@Bobgy Bobgy added area/sdk/dsl status/triaged Whether the issue has been explicitly triaged labels Mar 4, 2020
@Bobgy
Copy link
Contributor

Bobgy commented Mar 4, 2020

/assign @Ark-kun @numerology @hongye-sun

xiaohanhuang added a commit to xiaohanhuang/pipelines that referenced this issue Mar 4, 2020
@xiaohanhuang
add an optional name for dsl.Condition (kubeflow#3210)
a3897f8
xiaohanhuang added a commit to xiaohanhuang/pipelines that referenced this issue Mar 4, 2020
@xiaohanhuang
add an optional name for dsl.Condition (kubeflow#3210)
18375e8
k8s-ci-robot pushed a commit that referenced this issue Mar 6, 2020
@xiaohanhuang
add an optional name for dsl.Condition (#3210) (#3212)
e704067 
* add an optional name for dsl.Condition (#3210)

* add unit test
@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 11, 2020

Fixed by #3212

@Ark-kun Ark-kun closed this as completed Mar 11, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this issue Dec 9, 2020
@xiaohanhuang @Jeffwan
add an optional name for dsl.Condition (kubeflow#3210) (kubeflow#3212)
41df5dc 
* add an optional name for dsl.Condition (kubeflow#3210)

* add unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ark-kun Ark-kun

@numerology numerology

@hongye-sun hongye-sun

Labels
area/sdk/dsl kind/feature status/triaged Whether the issue has been explicitly triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Ark-kun @Bobgy @xiaohanhuang @numerology @hongye-sun