Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Container op should expose method to append volume/mount/envs #311

Closed
IronPan opened this issue Nov 19, 2018 · 2 comments
Closed

Container op should expose method to append volume/mount/envs #311

IronPan opened this issue Nov 19, 2018 · 2 comments
Assignees
@IronPan
Labels
area/sdk/dsl/compiler

Comments

@IronPan
Copy link
Member

IronPan commented Nov 19, 2018

Currently it only exposes set() which will override any existing values.
https://github.com/kubeflow/pipelines/blob/master/sdk/python/kfp/dsl/_container_op.py#L158

Since these fields are list, we should support appending instead of setting.
@IronPan IronPan self-assigned this Nov 19, 2018
@gaoning777
Copy link
Contributor

Could this be closed since we have them in the DSL?

@vicaire
Copy link
Contributor

vicaire commented Mar 26, 2019

Resolving. Please reopen if anything is missing.

@vicaire vicaire closed this as completed Mar 26, 2019
Linchin pushed a commit to Linchin/pipelines that referenced this issue Apr 11, 2023
@zhenghuiwang @k8s-ci-robot
Add cron job to clean outdated disks (kubeflow#311)
1dfb512 
* delete outdated disks

* delete postsubmit

* print response
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this issue Mar 11, 2024
@animeshsingh
updating the intro (kubeflow#311)
20627ae 
some folks confused that its still not ready.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IronPan IronPan

Labels
area/sdk/dsl/compiler
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@IronPan @gaoning777 @vicaire