Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigQuery component doesn't allow empty GCSOutputPath #2606

Closed
parthmishra opened this issue Nov 13, 2019 · 2 comments
Closed

BigQuery component doesn't allow empty GCSOutputPath #2606

parthmishra opened this issue Nov 13, 2019 · 2 comments
Assignees
@Ark-kun
Labels
area/components kind/bug status/triaged Whether the issue has been explicitly triaged upstream_issue

Comments

@parthmishra
Copy link
Contributor

What happened:
When attempting to run a query using the BigQuery component, omitting the output_gcs_path argument results in the query job working but the component fails due to reading an empty output file bigquery/query-output-path.txt.

What did you expect to happen:
output_gcs_path is listed as an optional argument and therefore not supplying it should be fine and the query results should simply go to the designation table and not be exported to GCS.
@Ark-kun Ark-kun self-assigned this Nov 13, 2019
@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 13, 2019

Thank you for reporting the problem.
I've discovered and fixed this bug in the underlying Argo orchestrator: argoproj/argo-workflows#1653 which is released as part of Argo v2.4.1.
Unfortunately we have not yet upgraded to that version.

As a short-term fix we should change the component so that it does not produce empty artifacts.

@rmgogogo rmgogogo added kind/bug status/triaged Whether the issue has been explicitly triaged labels Nov 18, 2019
@parthmishra parthmishra mentioned this issue Nov 22, 2019
Closed
@Ark-kun
Copy link
Contributor

Ark-kun commented May 16, 2020

Short-term fixed by #3514
Properly fixed by #3537

@Ark-kun Ark-kun closed this as completed May 16, 2020
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
@yuzisun
Add constrains for numpy<1.24.0 (kubeflow#2606)
674f1ae 
* Add constrains for numpy<1.24.0

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Fix mlserver slim overlay

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Update to kube 1.23 for test

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ark-kun Ark-kun

Labels
area/components kind/bug status/triaged Whether the issue has been explicitly triaged upstream_issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Ark-kun @rmgogogo @parthmishra @hongye-sun