Client SDK Bug in the create_run_from_pipeline_package function #2357
Assignees
Labels
Comments
|
fixing in #2355 |
|
Fixed in #2355 |
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this issue
Oct 22, 2023
* Take disableIstioVirtualHost and urlScheme from ingressConfig Commit 48f45eb introduced disableIstioVirtualHost in ingressConfig and updated various functions to take this as an option. Update codebase to use ingressConfig directly. This way we can use the urlScheme and later on the pathTemplate without changing the prototype of the methods. Signed-off-by: Dimitris Aragiorgis <dimara@arrikto.com> * Introduce pathTemplate in ingressConfig Extend the IngressConfig struct with a pathTemplate field to enable path-based routing. If this is set the user must also provide ingressDomain and urlScheme. Validate the given template just by trying to parse it. The user is responsible for providing a valid template that is unique for a given inference service, for example, by using both namespace and name in the template. Introduce a path module (similar to the existing domain) that has GenerateUrlPath() helper. This will will try to render the pathTemplate based on the name and namespace of an isvc. Add unittests for this new helper. Refs kserve/kserve#2257 Signed-off-by: Dimitris Aragiorgis <dimara@arrikto.com> Signed-off-by: Kostis Andriopoulos <kandrio@arrikto.com> * Add path-based rule in top-level VirtualService Extend the Ingress reconciler to add a matching rule in the top-level VirtualService of each InferenceService if the 'pathTemplate' field is not empty. Specifically adds a VirtualService rule that redirects path-based requests from the public to the local gateway. Also extend the list of hosts to include the ingressDomain. Modify existing getServiceUrl() to take into account pathTemplate. Update unittests accordingly. Refs kserve/kserve#2257 Signed-off-by: Dimitris Aragiorgis <dimara@arrikto.com> Signed-off-by: Kostis Andriopoulos <kandrio@arrikto.com> * Add e2e tests for path-based routing Extend e2e tests to test path-based routing. Specifically, extend the test-fast job, to patch the inferenceservice-config to set pathTemplate, ingressDomain, and urlScheme and re-run the fast tests. Update predict() to take into account service urls with paths. Closes kserve/kserve#2257 Signed-off-by: Dimitris Aragiorgis <dimara@arrikto.com> --------- Signed-off-by: Dimitris Aragiorgis <dimara@arrikto.com> Signed-off-by: Kostis Andriopoulos <kandrio@arrikto.com> Co-authored-by: Dimitris Aragiorgis <dimara@arrikto.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
lacking the run_id param to the wait_for_run_completion func:
pipelines/sdk/python/kfp/_client.py
Line 361 in 709d7e2
The text was updated successfully, but these errors were encountered: