Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove container build magic #2251

Closed
SinaChavoshi opened this issue Sep 27, 2019 · 2 comments
Closed

Remove container build magic #2251

SinaChavoshi opened this issue Sep 27, 2019 · 2 comments
Assignees
@Ark-kun
Labels
priority/p1 sdk/containers status/triaged Whether the issue has been explicitly triaged
Milestone
M10

Comments

@SinaChavoshi
Copy link
Contributor

SinaChavoshi commented Sep 27, 2019 •
edited
Loading

This request is to remove the container build magic, this is an alternative path that can become out dated and create confusion for customers.

Suggestion is to remove the functionality and add a proper error message indicating that the library is deprecated and removed.

there are two sections that need to be removed , pipelines/sdk/python/kfp/notebook/_magic.py as well as the corresponding library def build_docker_image under pipelines/sdk/python/kfp/containers/_component_builder.py
@jessiezcc jessiezcc added this to the M10 milestone Sep 27, 2019
@jessiezcc jessiezcc added the status/triaged Whether the issue has been explicitly triaged label Sep 27, 2019
@Ark-kun
Copy link
Contributor

Ark-kun commented Sep 30, 2019

There is a PR to deprecate it. Should we remove it right away? #2266

@Ark-kun
Copy link
Contributor

Ark-kun commented Oct 12, 2019

Fixed by #2266 and #2276

@Ark-kun Ark-kun closed this as completed Oct 12, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
@andyi2it
Fix grpc is not working with logger (kubeflow#2463)
6ad9b45 
* Fix grpc is not working with logger (kubeflow#2251)

* Fix grpc inference request fails when used with logger.

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

* Added e2e for grpc with logger

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

Fixed lint errors

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

Added logs to debug failing grpc in workflow

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

Made changes in e2e to use grpc with logger using torchserve

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

added grpc trace for debugging

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

Made changes to move logger grpc test from torchserve to the custom model

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

* Fixed lint errors

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

* Cleanup debug changes

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

* Made changes to fix review suggestions

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ark-kun Ark-kun

Labels
priority/p1 sdk/containers status/triaged Whether the issue has been explicitly triaged
Projects
None yet
Milestone
M10
Development

No branches or pull requests
3 participants
@Ark-kun @SinaChavoshi @jessiezcc