Our tests fail on external PRs #215
Assignees
Labels
Comments
|
@Ark-kun, could you please provide more details? Why do the test fail on external PRs? Note that tests should ideally not be automatically triggered on external PR. |
|
Assuming that this is resolved. |
|
Fixed by #315 |
Linchin
pushed a commit
to Linchin/pipelines
that referenced
this issue
Apr 11, 2023
* Recreate k8s client on auth failure * Recreate client on each call * Fix syntax * Remove debug msg * Try to fix unit tests
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this issue
Oct 22, 2023
* invoke credentials builder from model initializer * update test * remove sa annotation * fix initContainer typo * fix status code on configmap not found * format changes * update test to incl. credbuilder * add credentials unit tests
HumairAK
pushed a commit
to red-hat-data-services/data-science-pipelines
that referenced
this issue
Mar 11, 2024
* Update mdtoc.sh script to remove colons from anchor links * Add check_mdtoc target to Makefile * Add make check_mdtoc to Travis/CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See the failing tests in these PRs:
#164
#212
The root cause: image builders fail, because they try to check-out the PR's commit themselves and fail to do so. I've written about a long-term solution to this problem in #200
Note that this issue is not caused by #165 . This problem existed even in our private repo. (See https://github.com/googleprivate/ml/pull/1535)
Truth is #165 makes a step in the direction of short-term fixing this, but it's only half way there.
As short term fix would be to add
git fetch https://github.com/<fork_org>/<fork_repo>.git <fork_branch>before the merge.The text was updated successfully, but these errors were encountered: