Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PipelineParam class should not expose TypeMeta #1420

Closed
Ark-kun opened this issue May 31, 2019 · 1 comment · Fixed by #1930
Closed

PipelineParam class should not expose TypeMeta #1420

Ark-kun opened this issue May 31, 2019 · 1 comment · Fixed by #1930

Comments

@Ark-kun
Copy link
Contributor

Ark-kun commented May 31, 2019

TypeMeta is an implementation detail type that we do not want to expose in public API

def __init__(self, name: str, op_name: str=None, value: str=None, param_type: TypeMeta=TypeMeta(), pattern: str=None):

https://github.com/kubeflow/pipelines/pull/938/files#diff-3ce4e39a5176a4d398491d2a85fea5c9R70

/cc @gaoning777

@gaoning777
Copy link
Contributor

agreed

Ark-kun added a commit that referenced this issue Aug 22, 2019
* SDK - Refactoring - Replaced the TypeMeta class
The PipelineParam no longer exposes the private TypeMeta class
Fixes #1420

The refactoring PR is part of a series of PR which unifies the metadata and specification types.
numerology pushed a commit to numerology/pipelines that referenced this issue Aug 23, 2019
commit 7b6825d
Author: hongye-sun <43763191+hongye-sun@users.noreply.github.com>
Date:   Thu Aug 22 18:23:18 2019 -0700

    Update changelog for 0.1.27 (kubeflow#1935)

    * Update changelog for 0.1.27

    * Revert unexpected changes.

commit 336760c
Author: IronPan <yangpa@google.com>
Date:   Thu Aug 22 17:47:18 2019 -0700

    sync namespaced install file (kubeflow#1932)

commit 55d62fe
Author: Hamed <hamedhsn@gmail.com>
Date:   Fri Aug 23 01:09:18 2019 +0100

    Support Affinity for ContainerOps (kubeflow#1886)

commit d15697b
Author: Animesh Singh <singhan@us.ibm.com>
Date:   Thu Aug 22 16:29:17 2019 -0700

    Initial kfserving pipeline component (kubeflow#1838)

    * initial kfserving pipeline component

    * changing some descriptions

    * adding action as an input, and pinning versions

    * moving Dockerfile in correct location

    * adding namespace to delete

commit 119405d
Author: hongye-sun <43763191+hongye-sun@users.noreply.github.com>
Date:   Thu Aug 22 15:49:29 2019 -0700

    upgrade backend image versions (kubeflow#1918)

commit c01315a
Author: Alexey Volkov <avolkov@google.com>
Date:   Thu Aug 22 15:31:24 2019 -0700

    SDK - Refactoring - Replaced the TypeMeta class (kubeflow#1930)

    * SDK - Refactoring - Replaced the TypeMeta class
    The PipelineParam no longer exposes the private TypeMeta class
    Fixes kubeflow#1420

    The refactoring PR is part of a series of PR which unifies the metadata and specification types.

commit 736c7a5
Author: IronPan <yangpa@google.com>
Date:   Thu Aug 22 15:29:19 2019 -0700

    clean up owner file (kubeflow#1928)

commit 5abba66
Author: Kirin Patel <kirinpatel@gmail.com>
Date:   Thu Aug 22 14:45:18 2019 -0700

    Add pipeline id to pipeline summary card (kubeflow#1927)

    * Added pipeline id to pipeline summary card

    * Updated PipelineDetails.test.tsx.snap

commit 3c8952e
Author: Kirin Patel <kirinpatel@gmail.com>
Date:   Thu Aug 22 13:57:20 2019 -0700

    Add TFDV, TFMA, and Table visualization support for Python based visualizations (kubeflow#1898)

    * Added table and tfdv visualization

    Also fixed issue surrounding ApiVisualizationType enum

    * Fixed table visualization

    * Removed byte limit
    * Fixed issue where headers would not properly be applied
    * Fixed issue where table would not be intractable

    * Updated table visualizaiton to reflect changes made to dependency injection

    * Fixed bug where checking if headers is provided to table visualizations could crash visualization

    * Added TFMA visualization

    * Updated new visualizations to match syntax of kubeflow#1878

    * Updated test snapshots to account for TFMA visualization

    * Small if statement synax changes

    * Add flake8 noqa comments to table.py and tfma.py

commit db6c9b4
Author: dushyanthsc <43390008+dushyanthsc@users.noreply.github.com>
Date:   Thu Aug 22 13:11:18 2019 -0700

    pipeline-lite: Introduce metadata component to pipeline-lite (kubeflow#1840)

    This change introduces the metadata component to pipeline-lite
    installation. This installation:

      1. Does not include metadata-ui
      2. mysql installation is used instead of metadata-db
      3. Replica count has been reduced 1 instead of 3
numerology pushed a commit that referenced this issue Aug 23, 2019
)

* Remove redundant import.

* Simplify sample_test.yaml by using withItem syntax.

* Simplify sample_test.yaml by using withItem syntax.

* Change dict to str in withItems.

* Add back coveralls.

* Squashed commit of the following:

commit 7dbca1a
Author: Ning <ngao@google.com>
Date:   Fri Aug 16 12:06:37 2019 -0700

    update gcloud ml-engine to ai-platform (#1863)

commit e849f22
Author: Ryan Dawson <ryandawson@cantab.net>
Date:   Fri Aug 16 19:21:23 2019 +0100

    Seldon examples (#1405)

commit a6f3f40
Author: sina chavoshi <sina.chavoshi@gmail.com>
Date:   Fri Aug 16 09:56:09 2019 -0700

    Adding a sample for serving component (#1830)

    * Adding a sample for serving component

    * removed typo / updated based on PR feedback

    * fixing the jupyter rendering issue

    * adding pip3 for tensorflow

    * Fixed spelling error in VERSION

    * fix indentation based on review feedback

commit 54ff3e6
Author: Alexey Volkov <avolkov@google.com>
Date:   Fri Aug 16 01:22:31 2019 -0700

     SDK - Cleanup - Serialized PipelineParamTuple does not need value or type (#1469)

    * SDK - Refactoring - Serialized PipelineParam does not need type
    Only the types in non-serialized PipelineParams are ever used.

    * SDK - Refactoring - Serialized PipelineParam does not need value
    Default values are only relevant when PipelineParam is used in the pipeline function signature and even in this case compiler captures them explicitly from the pipelineParam objects in the signature.
    There is no other uses for them.

commit d2e94e4
Author: Riley Bauer <34456002+rileyjbauer@users.noreply.github.com>
Date:   Thu Aug 15 19:52:34 2019 -0700

    Fix run duration bug (#1827)

    * Allows durations >=24h and renames 'showLink' in RunList

    * Update, fix tests

commit d8eaeaa
Author: Alexey Volkov <avolkov@google.com>
Date:   Thu Aug 15 17:25:59 2019 -0700

    SDK - Preserving the pipeline input information in the compiled Workflow (#1381)

    * SDK - Preserving the pipeline metadata in the compiled Workflow

    * Stabilizing the DSL compiler tests

commit afe8a69
Author: Kirin Patel <kirinpatel@gmail.com>
Date:   Thu Aug 15 17:00:28 2019 -0700

    Reduce API usage by utilizing reference name in reference resource API (#1824)

    * Regenerated run api for frontend

    * Added support for reference name to resource reference API in frontend

    * Revert "Regenerated run api for frontend"

    * Addressed PR comments

    * Removed extra if statement by setting default value of parameter

    * Removed the whole comment

    * Addressed PR feedback

    * Addressed PR feedback

    * Simplified logic after offline discussion

commit ea67c99
Author: Kirin Patel <kirinpatel@gmail.com>
Date:   Thu Aug 15 16:18:35 2019 -0700

    Change how Variables are Provided to Visualizations (#1754)

    * Changed way visualization variables are passed from request to NotebookNode

    Visualization variables are now saved to a json file and loaded by a NotebookNode upon execution.

    * Updated roc_curve visualization to reflect changes made to dependency injection

    * Fixed bug where checking if is_generated is provided to roc_curve visualization would crash visualizaiton

    Also changed ' -> "

    * Changed text_exporter to always sort variables by key for testing

    * Addressed PR suggestions

commit d238bef
Author: Jiaxiao Zheng <jxzheng@google.com>
Date:   Thu Aug 15 12:55:29 2019 -0700

    Add back coveralls. (#1849)

    * Remove redundant import.

    * Simplify sample_test.yaml by using withItem syntax.

    * Simplify sample_test.yaml by using withItem syntax.

    * Change dict to str in withItems.

    * Add back coveralls.

commit 0517114
Author: Riley Bauer <34456002+rileyjbauer@users.noreply.github.com>
Date:   Thu Aug 15 12:28:35 2019 -0700

    Reduce getPipeline calls in RunList (#1852)

    * Skips calling getPipeline in RunList if the pipeline name is in the pipeline_spec

    * Update fixed data to include pipeline names in pipeline specs

    * Remove redundant getRuns call

commit 39e5840
Author: IronPan <yangpa@google.com>
Date:   Thu Aug 15 11:04:34 2019 -0700

    Add retry button in Pipeline UI (#1782)

    * add retry button

    * add retry button

    * add retry button

    * address comments

    * fix tests

    * fix tests

    * update image

    * Update StatusUtils.test.tsx

    * Update RunDetails.test.tsx

    * Update Buttons.ts

    * update test

    * update frontend

    * update

    * update

    * addrerss comments

    * update test

* WIP: rewrite sample test infra
step 1, presubmit check triggered by fire.

* WIP: rewrite sample test infra
step 2, add ComponentTest class

* WIP: rewrite sample test infra
Rewrite dockerfile

* Fixing

* Refactor the logic of run_test.sh into sample_test_launcher.py

* Fix exit_code

* Fix imports and add todo

* Squashed commit of the following:

commit 0ed5819
Author: Yuan (Bob) Gong <gongyuan94@gmail.com>
Date:   Tue Aug 20 08:13:31 2019 +0800

    Refactor presubmit-tests-with-pipeline-deployment.sh to run in other projects (#1732)

    * Refactor presubmit-tests-with-pipeline-deployment.sh so that it can be run from a different project

    * Simplify getting service account from cluster.

    * Copy image builder image instead of granting permission

    * Add missed yes command

    * fix stuff

    * Let other usages of image-builder image become configurable

    * let test workflow use image builder image

* Clean up.

* Fix launcher flag.

* switch to sys.execxutable.

* Fix bugs

* Add copy blob util function
fix issues,
and
Squashed commit of the following:

commit 0ed5819
Author: Yuan (Bob) Gong <gongyuan94@gmail.com>
Date:   Tue Aug 20 08:13:31 2019 +0800

    Refactor presubmit-tests-with-pipeline-deployment.sh to run in other projects (#1732)

    * Refactor presubmit-tests-with-pipeline-deployment.sh so that it can be run from a different project

    * Simplify getting service account from cluster.

    * Copy image builder image instead of granting permission

    * Add missed yes command

    * fix stuff

    * Let other usages of image-builder image become configurable

    * let test workflow use image builder image

commit 0369a4c
Author: Ajay Gopinathan <ajaygopinathan@google.com>
Date:   Fri Aug 16 21:02:07 2019 -0700

    Update manifests to point to 0.26 release. (#1870)

commit 2b246bc
Author: Alexey Volkov <avolkov@google.com>
Date:   Fri Aug 16 19:54:07 2019 -0700

    SDK - Tests - Improved the "ContainerOp.set_retry" test (#1843)

    Properly testing the feature isntead of just comparing with golden data.

commit d66508d
Author: Ajay Gopinathan <ajaygopinathan@google.com>
Date:   Fri Aug 16 18:42:48 2019 -0700

    Update changelog for 0.1.26 (#1872)

    * Update changelog for 0.1.26

    * Update changelog.

commit 1d99704
Author: Alexey Volkov <avolkov@google.com>
Date:   Fri Aug 16 18:24:09 2019 -0700

    SDK - Fixed string comparisons (#1756)

commit 6d5ffa2
Author: Ajay Gopinathan <ajaygopinathan@google.com>
Date:   Fri Aug 16 16:57:33 2019 -0700

    Remove copying of tfx data for cloudbuild release steps. (#1871)

commit de538aa
Author: Ning <ngao@google.com>
Date:   Fri Aug 16 15:53:07 2019 -0700

    add compile step in the samples to generate zip files (#1866)

    * add compile step in the samples to generate zip files

commit 5bcc665
Author: Ajay Gopinathan <ajaygopinathan@google.com>
Date:   Fri Aug 16 13:58:23 2019 -0700

    Update Python SDK versions for release. (#1860)

commit 0d898cb
Author: Ajay Gopinathan <ajaygopinathan@google.com>
Date:   Fri Aug 16 13:16:11 2019 -0700

    Release 0517114 (#1859)

    * Updated component images to version 0517114

    * Updated components to version 48dd338

commit 7dbca1a
Author: Ning <ngao@google.com>
Date:   Fri Aug 16 12:06:37 2019 -0700

    update gcloud ml-engine to ai-platform (#1863)

commit e849f22
Author: Ryan Dawson <ryandawson@cantab.net>
Date:   Fri Aug 16 19:21:23 2019 +0100

    Seldon examples (#1405)

commit a6f3f40
Author: sina chavoshi <sina.chavoshi@gmail.com>
Date:   Fri Aug 16 09:56:09 2019 -0700

    Adding a sample for serving component (#1830)

    * Adding a sample for serving component

    * removed typo / updated based on PR feedback

    * fixing the jupyter rendering issue

    * adding pip3 for tensorflow

    * Fixed spelling error in VERSION

    * fix indentation based on review feedback

commit 54ff3e6
Author: Alexey Volkov <avolkov@google.com>
Date:   Fri Aug 16 01:22:31 2019 -0700

     SDK - Cleanup - Serialized PipelineParamTuple does not need value or type (#1469)

    * SDK - Refactoring - Serialized PipelineParam does not need type
    Only the types in non-serialized PipelineParams are ever used.

    * SDK - Refactoring - Serialized PipelineParam does not need value
    Default values are only relevant when PipelineParam is used in the pipeline function signature and even in this case compiler captures them explicitly from the pipelineParam objects in the signature.
    There is no other uses for them.

commit d2e94e4
Author: Riley Bauer <34456002+rileyjbauer@users.noreply.github.com>
Date:   Thu Aug 15 19:52:34 2019 -0700

    Fix run duration bug (#1827)

    * Allows durations >=24h and renames 'showLink' in RunList

    * Update, fix tests

commit d8eaeaa
Author: Alexey Volkov <avolkov@google.com>
Date:   Thu Aug 15 17:25:59 2019 -0700

    SDK - Preserving the pipeline input information in the compiled Workflow (#1381)

    * SDK - Preserving the pipeline metadata in the compiled Workflow

    * Stabilizing the DSL compiler tests

commit afe8a69
Author: Kirin Patel <kirinpatel@gmail.com>
Date:   Thu Aug 15 17:00:28 2019 -0700

    Reduce API usage by utilizing reference name in reference resource API (#1824)

    * Regenerated run api for frontend

    * Added support for reference name to resource reference API in frontend

    * Revert "Regenerated run api for frontend"

    * Addressed PR comments

    * Removed extra if statement by setting default value of parameter

    * Removed the whole comment

    * Addressed PR feedback

    * Addressed PR feedback

    * Simplified logic after offline discussion

commit ea67c99
Author: Kirin Patel <kirinpatel@gmail.com>
Date:   Thu Aug 15 16:18:35 2019 -0700

    Change how Variables are Provided to Visualizations (#1754)

    * Changed way visualization variables are passed from request to NotebookNode

    Visualization variables are now saved to a json file and loaded by a NotebookNode upon execution.

    * Updated roc_curve visualization to reflect changes made to dependency injection

    * Fixed bug where checking if is_generated is provided to roc_curve visualization would crash visualizaiton

    Also changed ' -> "

    * Changed text_exporter to always sort variables by key for testing

    * Addressed PR suggestions

commit d238bef
Author: Jiaxiao Zheng <jxzheng@google.com>
Date:   Thu Aug 15 12:55:29 2019 -0700

    Add back coveralls. (#1849)

    * Remove redundant import.

    * Simplify sample_test.yaml by using withItem syntax.

    * Simplify sample_test.yaml by using withItem syntax.

    * Change dict to str in withItems.

    * Add back coveralls.

commit 0517114
Author: Riley Bauer <34456002+rileyjbauer@users.noreply.github.com>
Date:   Thu Aug 15 12:28:35 2019 -0700

    Reduce getPipeline calls in RunList (#1852)

    * Skips calling getPipeline in RunList if the pipeline name is in the pipeline_spec

    * Update fixed data to include pipeline names in pipeline specs

    * Remove redundant getRuns call

commit 39e5840
Author: IronPan <yangpa@google.com>
Date:   Thu Aug 15 11:04:34 2019 -0700

    Add retry button in Pipeline UI (#1782)

    * add retry button

    * add retry button

    * add retry button

    * address comments

    * fix tests

    * fix tests

    * update image

    * Update StatusUtils.test.tsx

    * Update RunDetails.test.tsx

    * Update Buttons.ts

    * update test

    * update frontend

    * update

    * update

    * addrerss comments

    * update test

* Fix default image prefix.

* Fix dependencies.

* Fix gs op

* Lint

* Fix papermill exec

* Init for componentTest

* Debugging.

* Try to fix the issue.
Possible cause: nteract/papermill#410

* Fix exit code

* Another fix.

* Squashed commit of the following:

commit 2592307
Author: Christian Clauss <cclauss@me.com>
Date:   Wed Aug 21 04:15:19 2019 +0200

    Undefined name 'e' in openvino (#1876)

    Discovered in #1721
    ```
    ./contrib/components/openvino/ovms-deployer/containers/evaluate.py:62:16: F821 undefined name 'e'
            except e:
                   ^
    ./contrib/components/openvino/ovms-deployer/containers/evaluate.py:63:50: F821 undefined name 'e'
                print("Can not read the image file", e)
                                                     ^
    ```
    Your review please @Ark-kun

commit 7b442f4
Author: Kirin Patel <kirinpatel@gmail.com>
Date:   Tue Aug 20 18:27:19 2019 -0700

    Created extensible code editor based on react-ace (#1855)

    * Created extensible code editor based on react-ace

    * Installed dependencies

    * Updated unit tests for Editor.tsx to test placeholder and value in simplified manner

    * Updated Editor unit tests to use snapshot testing where applicable

commit d11fae7
Author: Yuan (Bob) Gong <gongyuan94@gmail.com>
Date:   Wed Aug 21 08:25:20 2019 +0800

    Use KFP lite deployment for presubmit tests (#1808)

    * Refactor presubmit-tests-with-pipeline-deployment.sh so that it can be run from a different project

    * Simplify getting service account from cluster.

    * Migrate presubmit-tests-with-pipeline-deployment.sh to use kfp
    lightweight deployment.

    * Add option to cache built images to make debugging faster.

    * Fix cluster set up

    * Copy image builder image instead of granting permission

    * Add missed yes command

    * fix stuff

    * Let other usages of image-builder image become configurable

    * let test workflow use image builder image

    * Fix permission issue

    * Hide irrelevant error logs

    * Use shared service account key instead

    * Move test manifest to test folder

    * Move build-images.sh to a different script file

    * Update README.md

    * add cluster info dump

    * Use the same cluster resources as kubeflow deployment

    * Remove cluster info dump

    * Add timing to test log

    * cleaned up code

    * fix tests

    * address cr comments

    * Address cr comments

    * Enable image caching to improve retest speed

commit 0864faf
Author: IronPan <yangpa@google.com>
Date:   Tue Aug 20 14:09:19 2019 -0700

    Use single part as default (#1893)

    The data stored in artifact storage are usually small. Using multi-part is not strictly a requirement.
    Change the default to true to better support more platform out of box.

commit 6284dc1
Author: Christian Clauss <cclauss@me.com>
Date:   Tue Aug 20 22:01:18 2019 +0200

    IBM Watson samples: from six.moves import xrange (#1877)

    Discovered in #1721

    __xrange()__ was removed in Python 3 in favor of an improved version of __range()__.  This PR ensures equivalent functionality in both Python 2 and Python 3.

    ```
    ./samples/contrib/ibm-samples/watson/source/model-source-code/tf-model/input_data.py:100:40: F821 undefined name 'xrange'
                fake_image = [1.0 for _ in xrange(784)]
                                           ^
    ./samples/contrib/ibm-samples/watson/source/model-source-code/tf-model/input_data.py:102:41: F821 undefined name 'xrange'
                return [fake_image for _ in xrange(batch_size)], [
                                            ^
    ./samples/contrib/ibm-samples/watson/source/model-source-code/tf-model/input_data.py:103:37: F821 undefined name 'xrange'
                    fake_label for _ in xrange(batch_size)]
                                        ^
    ```

    @gaoning777 @Ark-kun Your reviews please.

commit 79c7bda
Author: Ning <ngao@google.com>
Date:   Tue Aug 20 09:24:56 2019 -0700

    fix unit tests and address some comments (#1892)

commit 6a7b28f
Author: Aakash Bajaj <aakashbajaj5589@gmail.com>
Date:   Tue Aug 20 14:07:33 2019 +0530

    gcp cred bug fix for multiple credentials in single pipeline (#1384)

    * gcp cred bug fix for multiple credentials in single pipeline

    * squash to remove conflict

commit 60fd70c
Author: Andy Wei <jwwandy@gmail.com>
Date:   Tue Aug 20 15:33:33 2019 +0800

    Let backend apiserver mysql dbname configurable (#1714)

    * let mysql dbname configurable

    * solve conflict

    * move declaration out to fix scope

commit 101a346
Author: olegchorny <oleg.chorny@gmail.com>
Date:   Tue Aug 20 08:33:47 2019 +0300

    'core' folder included to parameters related On-Premise cluster (#1751)

    * 'core' folder included to parameters related On-Premise cluster

    Update is required because this sample was migrated to the samples/core folder

    * Update README.md

commit 4c5d34f
Author: dushyanthsc <43390008+dushyanthsc@users.noreply.github.com>
Date:   Mon Aug 19 18:57:33 2019 -0700

    test/project-cleanup: Support to cleanup gke-clusters in test project (#1857)

    Change to add base framework for cleaning up resources in a GCP project.
    The resource specification is specified declaratively using a YAML file.

    As per current requirements this change only adds cleaning up of GKE
    clusters.

* Fix working dir

* Fix exit code format

* Remove kfp notebook sample using tfx:oss components.

* Refactor to reduce potential dup code.

* Clear unused const.

* Fix redundant check

* Add image injection for component test.

* Fix unused import

* Squash and merge from master

* Squashed commit of the following:

commit 41d39c1
Author: Kirin Patel <kirinpatel@gmail.com>
Date:   Wed Aug 21 19:38:31 2019 -0700

    Add run with json data as input within fixed-data.ts for UI testing and development (#1895)

    * Added run with json data as input

    * Changed run and uid to not be duplicates of hello-world-runtime

commit 851e7c8
Author: Kirin Patel <kirinpatel@gmail.com>
Date:   Wed Aug 21 19:04:31 2019 -0700

    Replace codemirror editor react component with react-ace editor component (#1890)

    * Replaced CodeMirror with Editor in PipelineDetails.tsx

    * Replaced codemirror in DetailsTable with react-ace

    * Removed codemirror

    * Updated unit tests for Editor.tsx to test placeholder and value in simplified manner

    * Updated DetailsTable.test.tsx.snap to reflect changes made in DetailsTable.tsx

    * Updated PipelineDetails test snapshot

    * Changed width of Editor in DetailsTable to be 100% instead of 300px

    * Revert "Updated unit tests for Editor.tsx to test placeholder and value in simplified manner"

    This reverts commit 40103f2.

commit 8c3d6fe
Author: Kirin Patel <kirinpatel@gmail.com>
Date:   Wed Aug 21 18:30:33 2019 -0700

    Add visualization-server service to lightweight deployment (#1844)

    * Add visualization-server service to lightweight deployment

    * Addressed PR suggestions

    * Added field to determine if visualization service is active and fixed unit tests for visualization_server.go

    * Additional small fixes

    * port change from 88888 -> 8888
    * version change from 0.1.15 -> 0.1.26
    * removed visualization-server from base/kustomization.yaml

    * Fixed visualization_server_test.go to reflect new changes

    * Changed implementation to be fail fast

    * Changed host name to be constant provided by environment

    * Added retry and extracted isVisualizationServiceAlive logic to function

    * Fixed deployment.yaml file

    * Fixed serviceURL configuration issuse

    serviceURL is now properly obtained from the environment, the service ip address and port are used rather than service name and namespace

    * Added log message to indicate when visualization service is unreachable

    * Addressed PR comments

    * Removed _HTTP

commit ad307db
Author: Eterna2 <eterna2@hotmail.com>
Date:   Thu Aug 22 08:52:32 2019 +0800

    [Bug Fix] Delete ResourceOp should not have output parameters (#1822)

    * Fix bug where delete resource op should not have success_condition, failure_condition, and output parameters

    * remove unnecessary whitespace

    * compiler test for delete resource ops should retrieve templates from spec instead of root

commit 593f25a
Author: Alexey Volkov <avolkov@google.com>
Date:   Wed Aug 21 17:16:33 2019 -0700

    Collecting coverage when running python tests (#898)

    * Collecting coiverage when running python tests

    * Added coveralls to python unit tests

    * Try removing the PATH modification

    * Specifying coverage run --source

    * Using the installed package

    * Try getting the correct coverage paths

commit 553885f
Author: Alexey Volkov <avolkov@google.com>
Date:   Wed Aug 21 16:38:12 2019 -0700

    SDK - Components - Fixed ModelBase comparison bug (#1874)

commit 2622c67
Author: IronPan <yangpa@google.com>
Date:   Wed Aug 21 16:37:53 2019 -0700

    cleanup test dir (#1914)

commit 203307d
Author: Alexey Volkov <avolkov@google.com>
Date:   Wed Aug 21 16:37:21 2019 -0700

    SDK - Lightweight - Fixed custom types in multi-output case (#1875)

    The type was mistakenly serialized as `_ForwardRef('CustomType')`.
    The input parameter types and single-output types were not affected.

commit 2e7f2d4
Author: IronPan <yangpa@google.com>
Date:   Wed Aug 21 16:36:35 2019 -0700

    Add cloud sql and gcs connection for pipeline-lite deployment (#1910)

    * restructure

    * working example

    * working example

    * move mysql

    * moving minio and mysql out

    * add gcp

    * add files

    * fix test

commit 9adf163
Author: Alexey Volkov <avolkov@google.com>
Date:   Wed Aug 21 16:29:54 2019 -0700

    SDK - Airflow - Fixed bug in airflow op creation (#1911)

    This PR fixes a bug in AirFlow op creation.
    The `_run_airflow_op` helper function was not captured along with the `_run_airflow_op_closure` function, because they belong to different modules (`_run_airflow_op_closure` was module-less).
    This was not discovered during the notebook testing of the code since in that environment the `_run_airflow_op` was also module-less as it was defined in a notebook (not in .py file).

commit 7ec5697
Author: hongye-sun <43763191+hongye-sun@users.noreply.github.com>
Date:   Wed Aug 21 16:06:31 2019 -0700

    Release 151c534 (#1916)

    * Updated component images to version 151c534

    * Updated components to version a97f1d0

    * Update setup.py

    * Update setup.py

commit 7e062ce
Author: IronPan <yangpa@google.com>
Date:   Wed Aug 21 15:14:31 2019 -0700

    Update README.md

commit 8e1e823
Author: Christian Clauss <cclauss@me.com>
Date:   Thu Aug 22 00:04:31 2019 +0200

    Lint Python code for undefined names (#1721)

    * Lint Python code for undefined names

    * Lint Python code for undefined names

    * Exclude tfdv.py to workaround an overzealous pytest

    * Fixup for tfdv.py

    * Fixup for tfdv.py

    * Fixup for tfdv.py

* # Conflicts:
#	sdk/python/tests/components/test_python_op.py

* Fix version for papermill

* Squashed commit of the following:

commit af456bc
Author: Eterna2 <eterna2@hotmail.com>
Date:   Fri Aug 23 02:08:33 2019 +0800

    [front-end-server] Allow viewer:tensorboard podTemplateSpec to be customizable (#1906)

    * Allow front-end server to provide custom viewer podTemplateSpec via path/configmap

    * Fix JSON.parse input to string

commit 06b7ad6
Author: IronPan <yangpa@google.com>
Date:   Thu Aug 22 10:03:28 2019 -0700

    Cleanup pipeline-lite deployment (#1921)

    * restructure

    * working example

    * working example

    * move mysql

    * moving minio and mysql out

    * add gcp

    * add files

    * fix test

    * extract parameters to single place

    * update

    * update readme

    * update readme

    * address pr comment

commit 56160f1
Author: Kirin Patel <kirinpatel@gmail.com>
Date:   Thu Aug 22 09:26:33 2019 -0700

    Added support for environment specified kernel timeout (#1920)

* Fix google-cloud-storage and google fire version info.

* Delete run_test.sh

* Merge from kfp master

* Squashed commit of the following:

commit 7b6825d
Author: hongye-sun <43763191+hongye-sun@users.noreply.github.com>
Date:   Thu Aug 22 18:23:18 2019 -0700

    Update changelog for 0.1.27 (#1935)

    * Update changelog for 0.1.27

    * Revert unexpected changes.

commit 336760c
Author: IronPan <yangpa@google.com>
Date:   Thu Aug 22 17:47:18 2019 -0700

    sync namespaced install file (#1932)

commit 55d62fe
Author: Hamed <hamedhsn@gmail.com>
Date:   Fri Aug 23 01:09:18 2019 +0100

    Support Affinity for ContainerOps (#1886)

commit d15697b
Author: Animesh Singh <singhan@us.ibm.com>
Date:   Thu Aug 22 16:29:17 2019 -0700

    Initial kfserving pipeline component (#1838)

    * initial kfserving pipeline component

    * changing some descriptions

    * adding action as an input, and pinning versions

    * moving Dockerfile in correct location

    * adding namespace to delete

commit 119405d
Author: hongye-sun <43763191+hongye-sun@users.noreply.github.com>
Date:   Thu Aug 22 15:49:29 2019 -0700

    upgrade backend image versions (#1918)

commit c01315a
Author: Alexey Volkov <avolkov@google.com>
Date:   Thu Aug 22 15:31:24 2019 -0700

    SDK - Refactoring - Replaced the TypeMeta class (#1930)

    * SDK - Refactoring - Replaced the TypeMeta class
    The PipelineParam no longer exposes the private TypeMeta class
    Fixes #1420

    The refactoring PR is part of a series of PR which unifies the metadata and specification types.

commit 736c7a5
Author: IronPan <yangpa@google.com>
Date:   Thu Aug 22 15:29:19 2019 -0700

    clean up owner file (#1928)

commit 5abba66
Author: Kirin Patel <kirinpatel@gmail.com>
Date:   Thu Aug 22 14:45:18 2019 -0700

    Add pipeline id to pipeline summary card (#1927)

    * Added pipeline id to pipeline summary card

    * Updated PipelineDetails.test.tsx.snap

commit 3c8952e
Author: Kirin Patel <kirinpatel@gmail.com>
Date:   Thu Aug 22 13:57:20 2019 -0700

    Add TFDV, TFMA, and Table visualization support for Python based visualizations (#1898)

    * Added table and tfdv visualization

    Also fixed issue surrounding ApiVisualizationType enum

    * Fixed table visualization

    * Removed byte limit
    * Fixed issue where headers would not properly be applied
    * Fixed issue where table would not be intractable

    * Updated table visualizaiton to reflect changes made to dependency injection

    * Fixed bug where checking if headers is provided to table visualizations could crash visualization

    * Added TFMA visualization

    * Updated new visualizations to match syntax of #1878

    * Updated test snapshots to account for TFMA visualization

    * Small if statement synax changes

    * Add flake8 noqa comments to table.py and tfma.py

commit db6c9b4
Author: dushyanthsc <43390008+dushyanthsc@users.noreply.github.com>
Date:   Thu Aug 22 13:11:18 2019 -0700

    pipeline-lite: Introduce metadata component to pipeline-lite (#1840)

    This change introduces the metadata component to pipeline-lite
    installation. This installation:

      1. Does not include metadata-ui
      2. mysql installation is used instead of metadata-db
      3. Replica count has been reduced 1 instead of 3

* Fix check_notebook_results args.

* Fix.

* Fix work dir path

* Fix global const naming convention

* Remove redundant check.

* Extract project name from result gcs dir.

* Add error catching

* Name change.

* Improve error catching.

* Improve error catching.

* naming correction.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants