Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagination broken in UI #1149

Closed
IronPan opened this issue Apr 12, 2019 · 3 comments · Fixed by #1153
Closed

Pagination broken in UI #1149

IronPan opened this issue Apr 12, 2019 · 3 comments · Fixed by #1153
Assignees
@neuromage
Labels
area/frontend kind/bug priority/p0

Comments

@IronPan
Copy link
Member

IronPan commented Apr 12, 2019

image

Here is the request. The filter is not null which is not in sync with page_token

https://8080-dot-3131389-dot-devshell.appspot.com/pipeline/apis/v1beta1/runs?page_token=eyJTb3J0QnlGaWVsZE5hbWUiOiJDcmVhdGVkQXRJblNlYyIsIlNvcnRCeUZpZWxkVmFsdWUiOjE1NTUwNTI5NDAsIktleUZpZWxkTmFtZSI6IlVVSUQiLCJLZXlGaWVsZFZhbHVlIjoiZDg5NWY5NWEtNWNmMS0xMWU5LWFkOTctNDIwMTBhODAwMGYyIiwiSXNEZXNjIjp0cnVlLCJGaWx0ZXIiOm51bGx9&page_size=10&sort_by=created_at%20desc&resource_reference_key.type=EXPERIMENT&resource_reference_key.id=f063f43d-e8c3-4e96-b320-7ef4c3900bc5&filter=%257B%2522predicates%2522%253A%255B%257B%2522key%2522%253A%2522storage_state%2522%252C%2522op%2522%253A%2522NOT_EQUALS%2522%252C%2522string_value%2522%253A%2522STORAGESTATE_ARCHIVED%2522%257D%255D%257D
@IronPan
Copy link
Member Author

IronPan commented Apr 12, 2019

/assign @rileyjbauer @neuromage

@IronPan
Copy link
Member Author

IronPan commented Apr 12, 2019

decoding the filter:
{"predicates":[{"key":"storage_state","op":"NOT_EQUALS","string_value":"STORAGESTATE_ARCHIVED"}]}

decoding the page token:
{"SortByFieldName":"CreatedAtInSec","SortByFieldValue":1555052940,"KeyFieldName":"UUID","KeyFieldValue":"d895f95a-5cf1-11e9-ad97-42010a8000f2","IsDesc":true,"Filter":null}

@IronPan
Copy link
Member Author

IronPan commented Apr 12, 2019

Looks like we don't add filter in the token
https://github.com/kubeflow/pipelines/blob/master/backend/src/apiserver/list/list.go#L287

But we verify it for incoming request
https://github.com/kubeflow/pipelines/blob/master/backend/src/apiserver/list/list.go#L96

@rileyjbauer rileyjbauer mentioned this issue Apr 12, 2019
Closed
@neuromage neuromage mentioned this issue Apr 12, 2019
Merged
@rileyjbauer rileyjbauer mentioned this issue Jun 19, 2019
Closed
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
@theofpa
Introduce defaultTimeout for predictor and apply in tfserving (kubefl…
42d044d 
…ow#1149)

* Introduce serving defaultTimeout in configmap and apply in Tensorflow model server

* Add tests for serving defaultTimeout in tfserving

* typo in test configmap

* Run gen-crd-apidocs to add the serving defaultTimeout of tfserving

* Add description for serving defaultTimeout in apidocs

* Change defaultTimeout on v1alpha2 to int64 instead of string

* get timeout from user input or else use the component default timeout

* define defaultTimeout of v1alpha2 in seconds and improve tests based on the review

* run the apidocs to get the correct defaultTimeout description

* set timeout locally
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neuromage neuromage

Labels
area/frontend kind/bug priority/p0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add filter to next page token so it applies to subsequently requested pages neuromage/pipelines
4 participants
@neuromage @IronPan @vicaire @rileyjbauer