Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline submission fails when ContainerOp has numbers as command line arguments #1121

Closed
Ark-kun opened this issue Apr 9, 2019 · 0 comments · Fixed by #1197
Closed

Pipeline submission fails when ContainerOp has numbers as command line arguments #1121

Ark-kun opened this issue Apr 9, 2019 · 0 comments · Fixed by #1197

Comments

@Ark-kun
Copy link
Contributor

Ark-kun commented Apr 9, 2019

Root cause: In Kubernetes/Argo, the valid type of command-line arguments is string. The ContainerOp class does not convert all arguments to strings, so the compiler produces invalid Workflows.

The pipeline spec is invalid.: InvalidInputError: Invalid argo workflow format. Workflow:
...
json: cannot unmarshal number into Go struct field Container.args of type string

Interestingly, argo lint does not catch the problem. (Is that because Argo uses yaml.Unmarshal which does not validate enough?)

@Ark-kun Ark-kun self-assigned this Apr 9, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
* Use kfserving-examples bucket

* Fix onnx style model example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants