Adds many more tests, cleans-up PipelineSelector a bit, and fixes bug…

… in Utils.ts
kubeflow · Nov 13, 2018 · f56e4ab · f56e4ab
1 parent 6268f20
commit f56e4ab
Show file tree

Hide file tree

Showing 6 changed files with 1,350 additions and 4,289 deletions.
diff --git a/frontend/src/components/UploadPipelineDialog.test.tsx b/frontend/src/components/UploadPipelineDialog.test.tsx
@@ -44,14 +44,14 @@ describe('UploadPipelineDialog', () => {
   it('calls close callback with null and empty string when canceled', () => {
     const spy = jest.fn();
     const tree = shallow(<UploadPipelineDialog open={false} onClose={spy} />);
-    tree.find('#cancelUploadBtn').at(0).simulate('click');
+    tree.find('#cancelUploadBtn').simulate('click');
     expect(spy).toHaveBeenCalledWith('', null, '');
   });
 
   it('calls close callback with null and empty string when dialog is closed', () => {
     const spy = jest.fn();
     const tree = shallow(<UploadPipelineDialog open={false} onClose={spy} />);
-    tree.find('WithStyles(Dialog)').at(0).simulate('close');
+    tree.find('WithStyles(Dialog)').simulate('close');
     expect(spy).toHaveBeenCalledWith('', null, '');
   });
 
@@ -60,7 +60,7 @@ describe('UploadPipelineDialog', () => {
     const tree = shallow(<UploadPipelineDialog open={false} onClose={spy} />);
     (tree.instance() as any)._dropzoneRef = { current: { open: () => null } };
     (tree.instance() as UploadPipelineDialog).handleChange('uploadPipelineName')({ target: { value: 'test name' } });
-    tree.find('#confirmUploadBtn').at(0).simulate('click');
+    tree.find('#confirmUploadBtn').simulate('click');
     expect(spy).toHaveBeenLastCalledWith('test name', null, '');
   });
 

diff --git a/frontend/src/lib/Utils.ts b/frontend/src/lib/Utils.ts
@@ -37,6 +37,7 @@ export function formatDateString(date: Date | string | undefined): string {
   }
 }
 
+// TODO: add tests
 export async function errorToMessage(error: any): Promise<string> {
   if (error instanceof Error) {
     return error.message;
@@ -46,7 +47,7 @@ export async function errorToMessage(error: any): Promise<string> {
     return await error.text();
   }
 
-  return JSON.stringify(error || '');
+  return JSON.stringify(error) || '';
 }
 
 export function enabledDisplayString(trigger: ApiTrigger | undefined, enabled: boolean): string {