Skip to content

Commit

Permalink
[Frontend] Change Tab name from source to YAML (#2951)
Browse files Browse the repository at this point in the history
* [Frontend] Change Tab name from source to YAML

to better reflect the actual content. Pipeline source should be its DSL def in Python.

* fix testdata

* fix testdata
  • Loading branch information
Jiaxiao Zheng authored Feb 1, 2020
1 parent 3c6ee19 commit e01bcd4
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion frontend/src/pages/PipelineDetails.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ class PipelineDetails extends Page<{}, PipelineDetailsState> {
<MD2Tabs
selectedTab={selectedTab}
onSwitch={(tab: number) => this.setStateSafe({ selectedTab: tab })}
tabs={['Graph', 'Source']}
tabs={['Graph', 'YAML']}
/>
<div className={commonCss.page}>
{selectedTab === 0 && (
Expand Down
16 changes: 8 additions & 8 deletions frontend/src/pages/__snapshots__/PipelineDetails.test.tsx.snap
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ exports[`PipelineDetails closes side panel when close button is clicked 1`] = `
tabs={
Array [
"Graph",
"Source",
"YAML",
]
}
/>
Expand Down Expand Up @@ -189,7 +189,7 @@ exports[`PipelineDetails collapses summary card when summary shown state is fals
tabs={
Array [
"Graph",
"Source",
"YAML",
]
}
/>
Expand Down Expand Up @@ -287,7 +287,7 @@ exports[`PipelineDetails opens side panel on clicked node, shows message when no
tabs={
Array [
"Graph",
"Source",
"YAML",
]
}
/>
Expand Down Expand Up @@ -463,7 +463,7 @@ exports[`PipelineDetails shows clicked node info in the side panel if it is in t
tabs={
Array [
"Graph",
"Source",
"YAML",
]
}
/>
Expand Down Expand Up @@ -733,7 +733,7 @@ exports[`PipelineDetails shows correct versions in version selector 1`] = `
tabs={
Array [
"Graph",
"Source",
"YAML",
]
}
/>
Expand Down Expand Up @@ -909,7 +909,7 @@ exports[`PipelineDetails shows empty pipeline details with empty graph 1`] = `
tabs={
Array [
"Graph",
"Source",
"YAML",
]
}
/>
Expand Down Expand Up @@ -1085,7 +1085,7 @@ exports[`PipelineDetails shows empty pipeline details with no graph 1`] = `
tabs={
Array [
"Graph",
"Source",
"YAML",
]
}
/>
Expand Down Expand Up @@ -1123,7 +1123,7 @@ exports[`PipelineDetails shows pipeline source code when config tab is clicked 1
tabs={
Array [
"Graph",
"Source",
"YAML",
]
}
/>
Expand Down

0 comments on commit e01bcd4

Please sign in to comment.