Skip to content

Commit

Permalink
fix(backend): Caching - Fixed deployer failure on Kubernetes v1.16+. F…
Browse files Browse the repository at this point in the history
…ixes #4627 (#4632)

* Backend - Caching - Fixed deployer failure on Kubernetes v1.16+

The sideEffects field field became required in v1 version of the resource kubernetes/kubernetes#79549

Also adding failurePolicy: Ignore, because the default value has changed to Fail in v1.16.

These changes are not needed for v1beta1, but I still add them for those cases as well for consistency.

* The admissionReviewVersions field became required in the v1 API in v1.16

See https://kubernetes.io/docs/reference/access-authn-authz/extensible-admission-controllers/#request
  • Loading branch information
Ark-kun authored Oct 20, 2020
1 parent f30aa09 commit dde7f9a
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,15 @@ webhooks:
namespace: ${NAMESPACE}
path: "/mutate"
caBundle: ${CA_BUNDLE}
failurePolicy: Ignore
rules:
- operations: [ "CREATE" ]
apiGroups: [""]
apiVersions: ["v1"]
resources: ["pods"]
sideEffects: None
timeoutSeconds: 5
objectSelector:
matchLabels:
pipelines.kubeflow.org/cache_enabled: "true"

admissionReviewVersions: ["v1beta1"]
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,13 @@ webhooks:
namespace: ${NAMESPACE}
path: "/mutate"
caBundle: ${CA_BUNDLE}
failurePolicy: Ignore
rules:
- operations: [ "CREATE" ]
apiGroups: [""]
apiVersions: ["v1"]
resources: ["pods"]
sideEffects: None
timeoutSeconds: 5
objectSelector:
matchLabels:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,11 @@ webhooks:
namespace: ${NAMESPACE}
path: "/mutate"
caBundle: ${CA_BUNDLE}
failurePolicy: Ignore
rules:
- operations: [ "CREATE" ]
apiGroups: [""]
apiVersions: ["v1"]
resources: ["pods"]
sideEffects: None
timeoutSeconds: 5

0 comments on commit dde7f9a

Please sign in to comment.