Skip to content

Commit

Permalink
feat(sdk): Components - Added Bool as a known type name (#4597)
Browse files Browse the repository at this point in the history
* SDK - Components - Added Bool as a known type name

Some components are already using this type name and are starting to fail due to more strict type checking during constant argument serialization.

* Fixed syntax error
  • Loading branch information
Ark-kun committed Oct 9, 2020
1 parent e87d74f commit d4fd6e1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sdk/python/kfp/components/_data_passing.py
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ def _deserialize_base64_pickle(s):
Converter([str], ['String', 'str'], _serialize_str, 'str', None),
Converter([int], ['Integer', 'int'], _serialize_int, 'int', None),
Converter([float], ['Float', 'float'], _serialize_float, 'float', None),
Converter([bool], ['Boolean', 'bool'], _serialize_bool, _bool_deserializer_code, _bool_deserializer_definitions),
Converter([bool], ['Boolean', 'Bool', 'bool'], _serialize_bool, _bool_deserializer_code, _bool_deserializer_definitions),
Converter([list], ['JsonArray', 'List', 'list'], _serialize_json, 'json.loads', 'import json'), # ! JSON map keys are always strings. Python converts all keys to strings without warnings
Converter([dict], ['JsonObject', 'Dictionary', 'Dict', 'dict'], _serialize_json, 'json.loads', 'import json'), # ! JSON map keys are always strings. Python converts all keys to strings without warnings
Converter([], ['Json'], _serialize_json, 'json.loads', 'import json'),
Expand Down

0 comments on commit d4fd6e1

Please sign in to comment.