Skip to content

Commit

Permalink
Removed duplicate CircularProgress within UI (#1625)
Browse files Browse the repository at this point in the history
* Removed duplicate CircularProgress

Previously, there was a CircularProgress to indicate that the UI is busy within the [RunDetails.tsx](https://github.com/kubeflow/pipelines/blob/24aae0d08205d9fc8f06a5bcc41e7d066d623817/frontend/src/pages/RunDetails.tsx#L213) and [SidePanel.tsx](https://github.com/kubeflow/pipelines/blob/a8b910787824d5fe08fc98f9f0dd8be54ac66e8e/frontend/src/components/SidePanel.tsx#L81). This removes the CircularProgress from RunDetails.tsx.

* Updated test snapshot
  • Loading branch information
ajchili authored and k8s-ci-robot committed Jul 16, 2019
1 parent 784c4f1 commit c7d19f0
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
3 changes: 0 additions & 3 deletions frontend/src/pages/RunDetails.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -209,9 +209,6 @@ class RunDetails extends Page<RunDetailsProps, RunDetailsState> {
selectedTab={sidepanelSelectedTab}
onSwitch={this._loadSidePaneTab.bind(this)} />

{this.state.sidepanelBusy &&
<CircularProgress size={30} className={commonCss.absoluteCenter} />}

<div className={commonCss.page}>
{sidepanelSelectedTab === SidePaneTab.ARTIFACTS && (
<div className={commonCss.page}>
Expand Down
4 changes: 0 additions & 4 deletions frontend/src/pages/__snapshots__/RunDetails.test.tsx.snap
Original file line number Diff line number Diff line change
Expand Up @@ -1251,10 +1251,6 @@ exports[`RunDetails logs tab switches to logs tab in side pane 1`] = `
]
}
/>
<WithStyles(CircularProgress)
className="absoluteCenter"
size={30}
/>
<div
className="page"
>
Expand Down

0 comments on commit c7d19f0

Please sign in to comment.