[UI] Hide empty resource op manifest tab in run details page (#3713)

* Hide manifest tab when empty * fix unit tests * Fix tests
kubeflow · May 8, 2020 · c5ceaf5 · c5ceaf5
1 parent eab5d31
commit c5ceaf5
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 20 deletions.
diff --git a/frontend/src/pages/RunDetails.test.tsx b/frontend/src/pages/RunDetails.test.tsx
@@ -42,10 +42,10 @@ const STEP_TABS = {
   INPUT_OUTPUT: 1,
   ML_METADATA: 2,
   VOLUMES: 3,
-  MANIFEST: 4,
-  LOGS: 5,
-  POD: 6,
-  EVENTS: 7,
+  LOGS: 4,
+  POD: 5,
+  EVENTS: 6,
+  MANIFEST: 7,
 };
 
 const NODE_DETAILS_SELECTOR = '[data-testid="run-details-node-details"]';

diff --git a/frontend/src/pages/RunDetails.tsx b/frontend/src/pages/RunDetails.tsx
@@ -82,10 +82,10 @@ enum SidePaneTab {
   INPUT_OUTPUT,
   ML_METADATA,
   VOLUMES,
-  MANIFEST,
   LOGS,
   POD,
   EVENTS,
+  MANIFEST,
 }
 
 interface SelectedNodeDetails {
@@ -312,10 +312,14 @@ class RunDetails extends Page<RunDetailsInternalProps, RunDetailsState> {
                                   'Input/Output',
                                   'ML Metadata',
                                   'Volumes',
-                                  'Manifest',
                                   'Logs',
                                   'Pod',
                                   'Events',
+                                  // NOTE: it's only possible to conditionally add a tab at the end
+                                  ...(WorkflowParser.getNodeManifest(workflow, selectedNodeId)
+                                    .length > 0
+                                    ? ['Manifest']
+                                    : []),
                                 ]}
                                 selectedTab={sidepanelSelectedTab}
                                 onSwitch={this._loadSidePaneTab.bind(this)}

diff --git a/frontend/src/pages/__snapshots__/RunDetails.test.tsx.snap b/frontend/src/pages/__snapshots__/RunDetails.test.tsx.snap
@@ -562,14 +562,13 @@ exports[`RunDetails logs tab does not load logs if clicked node status is skippe
             >
               <MD2Tabs
                 onSwitch={[Function]}
-                selectedTab={5}
+                selectedTab={4}
                 tabs={
                   Array [
                     "Artifacts",
                     "Input/Output",
                     "ML Metadata",
                     "Volumes",
-                    "Manifest",
                     "Logs",
                     "Pod",
                     "Events",
@@ -681,14 +680,13 @@ exports[`RunDetails logs tab keeps side pane open and on same tab when logs chan
             >
               <MD2Tabs
                 onSwitch={[Function]}
-                selectedTab={5}
+                selectedTab={4}
                 tabs={
                   Array [
                     "Artifacts",
                     "Input/Output",
                     "ML Metadata",
                     "Volumes",
-                    "Manifest",
                     "Logs",
                     "Pod",
                     "Events",
@@ -800,14 +798,13 @@ exports[`RunDetails logs tab loads and shows logs in side pane 1`] = `
             >
               <MD2Tabs
                 onSwitch={[Function]}
-                selectedTab={5}
+                selectedTab={4}
                 tabs={
                   Array [
                     "Artifacts",
                     "Input/Output",
                     "ML Metadata",
                     "Volumes",
-                    "Manifest",
                     "Logs",
                     "Pod",
                     "Events",
@@ -919,14 +916,13 @@ exports[`RunDetails logs tab switches to logs tab in side pane 1`] = `
             >
               <MD2Tabs
                 onSwitch={[Function]}
-                selectedTab={5}
+                selectedTab={4}
                 tabs={
                   Array [
                     "Artifacts",
                     "Input/Output",
                     "ML Metadata",
                     "Volumes",
-                    "Manifest",
                     "Logs",
                     "Pod",
                     "Events",
@@ -1045,7 +1041,6 @@ exports[`RunDetails opens side panel when graph node is clicked 1`] = `
                     "Input/Output",
                     "ML Metadata",
                     "Volumes",
-                    "Manifest",
                     "Logs",
                     "Pod",
                     "Events",
@@ -1290,7 +1285,6 @@ exports[`RunDetails shows clicked node message in side panel 1`] = `
                     "Input/Output",
                     "ML Metadata",
                     "Volumes",
-                    "Manifest",
                     "Logs",
                     "Pod",
                     "Events",
@@ -1742,7 +1736,6 @@ exports[`RunDetails switches to inputs/outputs tab in side pane 1`] = `
                     "Input/Output",
                     "ML Metadata",
                     "Volumes",
-                    "Manifest",
                     "Logs",
                     "Pod",
                     "Events",
@@ -1879,14 +1872,13 @@ exports[`RunDetails switches to manifest tab in side pane 1`] = `
             >
               <MD2Tabs
                 onSwitch={[Function]}
-                selectedTab={4}
+                selectedTab={7}
                 tabs={
                   Array [
                     "Artifacts",
                     "Input/Output",
                     "ML Metadata",
                     "Volumes",
-                    "Manifest",
                     "Logs",
                     "Pod",
                     "Events",
@@ -2038,7 +2030,6 @@ exports[`RunDetails switches to volumes tab in side pane 1`] = `
                     "Input/Output",
                     "ML Metadata",
                     "Volumes",
-                    "Manifest",
                     "Logs",
                     "Pod",
                     "Events",