Skip to content

Commit

Permalink
[Release] Various fixes to release script (#3918)
Browse files Browse the repository at this point in the history
* Update kustomize/base/params.env

* fix

* kfp sdk requirement updated to kfp_api_server<2.0.0

* Fix major minor parsing

* Also fix cloudbuild.yaml
  • Loading branch information
Bobgy committed Jun 5, 2020
1 parent 0324b2c commit b12023e
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 7 deletions.
3 changes: 2 additions & 1 deletion .cloudbuild.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,8 @@ steps:
- -ceux
- |
# Parse major minor version and save to a file for reusing in other steps.
cat /workspace/VERSION | sed -e "s#[^0-9]*\([0-9]*\)[.]\([0-9]*\)[.]\([0-9]*\)#\1.\2#" > /workspace/mm.ver
# e.g. 1.0.0-rc.1 and 1.0.1 are parsed as 1.0
echo $TAG_NAME | sed -e "s#\([0-9]\+[.][0-9]\+\)[.].*#\1#" > /workspace/mm.ver
# Tag for Hosted - Tag to hosted folder with MKP friendly name
- id: 'tagForHosted'
Expand Down
3 changes: 2 additions & 1 deletion .release.cloudbuild.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ steps:
- -ceux
- |
# Parse major minor version and save to a file for reusing in other steps.
echo $TAG_NAME | sed -e "s#[^0-9]*\([0-9]*\)[.]\([0-9]*\)[.]\([0-9]*\)#\1.\2#" > /workspace/mm.ver
# e.g. 1.0.0-rc.1 and 1.0.1 are parsed as 1.0
echo $TAG_NAME | sed -e "s#\([0-9]\+[.][0-9]\+\)[.].*#\1#" > /workspace/mm.ver
# Pull and retag images for pipeline components
- id: 'retagComponentImages'
Expand Down
1 change: 1 addition & 0 deletions RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ WIP: this document is still incomplete.

## Common Prerequisites

* OS: Linux (MacOS not supported yet due to different behavior of sed)
* Permissions needed
* Can create a branch in github.com/kubeflow/pipelines
* Tools that should be in your `$PATH`
Expand Down
3 changes: 3 additions & 0 deletions manifests/kustomize/hack/release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,6 @@ fi
echo "This release script uses yq, it can be downloaded at https://github.com/mikefarah/yq/releases/tag/3.3.0"
yq w -i "$DIR/../base/kustomization.yaml" images[*].newTag "$TAG_NAME"
yq w -i "$DIR/../env/gcp/inverse-proxy/kustomization.yaml" images[*].newTag "$TAG_NAME"

# Note, this only works in linux. TODO: make it MacOS sed compatible.
sed -i.bak -e "s|appVersion=.\+|appVersion=$TAG_NAME|g" "$DIR/../base/params.env"
2 changes: 1 addition & 1 deletion sdk/python/requirements.in
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jsonschema>=3.0.1
kubernetes>=8.0.0, <12.0.0

# kfp.Client
kfp-server-api>=0.2.5, <0.4.0 #Update the upper version whenever a new version of the kfp-server-api package is released. Update the lower version when there is a breaking change in kfp-server-api, or kfp sdk depends on new api changes in kfp-server-api.
kfp-server-api>=0.2.5, <2.0.0

# kfp.Client GCP auth
google-cloud-storage>=1.13.0
Expand Down
9 changes: 5 additions & 4 deletions sdk/python/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,11 @@
'requests_toolbelt>=0.8.0',
'cloudpickle',
# Update the upper version whenever a new major version of the
# kfp-server-api package is released. Update the lower version when there is
# a breaking change in kfp-server-api, or kfp sdk depends on new api changes
# in kfp-server-api.
'kfp-server-api>=0.2.5, <0.6.0',
# kfp-server-api package is released.
# Update the lower version when kfp sdk depends on new apis/fields in
# kfp-server-api.
# Note, please also update ./requirements.in
'kfp-server-api>=0.2.5, <2.0.0',
'jsonschema >= 3.0.1',
'tabulate',
'click',
Expand Down

0 comments on commit b12023e

Please sign in to comment.