-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(Backend + SDK): Update kfp backend and kubernetes sdk to support…
… ImagePullPolicy (#10417) * feat(Backend + SDK): Update kfp backend and kubernetes sdk to support ImagePullPolicy. Signed-off-by: Revital Sur <eres@il.ibm.com> * Fix format. Signed-off-by: Revital Sur <eres@il.ibm.com> * Update apiserver.csv. Signed-off-by: Revital Sur <eres@il.ibm.com> * Update licenses. Signed-off-by: Revital Sur <eres@il.ibm.com> --------- Signed-off-by: Revital Sur <eres@il.ibm.com>
- Loading branch information
Showing
10 changed files
with
234 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88 changes: 88 additions & 0 deletions
88
kubernetes_platform/python/test/unit/test_image_pull_policy.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| # Copyright 2024 The Kubeflow Authors | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| from google.protobuf import json_format | ||
| from kfp import dsl | ||
| from kfp import kubernetes | ||
|
|
||
|
|
||
| class TestImagePullPolicy: | ||
|
|
||
| def test_always(self): | ||
|
|
||
| @dsl.pipeline | ||
| def my_pipeline(): | ||
| task = comp() | ||
| kubernetes.set_image_pull_policy(task, 'Always') | ||
|
|
||
| assert json_format.MessageToDict(my_pipeline.platform_spec) == { | ||
| 'platforms': { | ||
| 'kubernetes': { | ||
| 'deploymentSpec': { | ||
| 'executors': { | ||
| 'exec-comp': { | ||
| 'imagePullPolicy': 'Always' | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| def test_if_not_present(self): | ||
|
|
||
| @dsl.pipeline | ||
| def my_pipeline(): | ||
| task = comp() | ||
| kubernetes.set_image_pull_policy(task, 'IfNotPresent') | ||
|
|
||
| assert json_format.MessageToDict(my_pipeline.platform_spec) == { | ||
| 'platforms': { | ||
| 'kubernetes': { | ||
| 'deploymentSpec': { | ||
| 'executors': { | ||
| 'exec-comp': { | ||
| 'imagePullPolicy': 'IfNotPresent' | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| def test_never(self): | ||
|
|
||
| @dsl.pipeline | ||
| def my_pipeline(): | ||
| task = comp() | ||
| kubernetes.set_image_pull_policy(task, 'Never') | ||
|
|
||
| assert json_format.MessageToDict(my_pipeline.platform_spec) == { | ||
| 'platforms': { | ||
| 'kubernetes': { | ||
| 'deploymentSpec': { | ||
| 'executors': { | ||
| 'exec-comp': { | ||
| 'imagePullPolicy': 'Never' | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
|
|
||
| @dsl.component | ||
| def comp(): | ||
| pass |