Only pending or running workflows are considered not-final (#3940)

* only pending or running workflows are considered not-final * rephrase comment
kubeflow · Jun 9, 2020 · 5f9e56a · 5f9e56a
1 parent 57f415d
commit 5f9e56a
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/backend/src/common/util/workflow.go b/backend/src/common/util/workflow.go
@@ -283,7 +283,8 @@ func (w *Workflow) FindObjectStoreArtifactKeyOrEmpty(nodeID string, artifactName
 
 // IsInFinalState whether the workflow is in a final state.
 func (w *Workflow) IsInFinalState() bool {
-	if w.Status.Phase == workflowapi.NodeSucceeded || w.Status.Phase == workflowapi.NodeFailed {
+	// Workflows in the statuses other than pending or running are considered final.
+	if w.Status.Phase == workflowapi.NodeSucceeded || w.Status.Phase == workflowapi.NodeFailed || w.Status.Phase == workflowapi.NodeError || w.Status.Phase == workflowapi.NodeSkipped {
 		return true
 	}
 	return false