Skip to content

Commit

Permalink
manifests/metadata: Metadata server invocation change
Browse files Browse the repository at this point in the history
Change to update invocation to use command line parameters as against
using proto text.
  • Loading branch information
dushyanthsc committed Sep 10, 2019
1 parent a4fa1ed commit 4522171
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 30 deletions.
2 changes: 0 additions & 2 deletions manifests/kustomize/base/metadata/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,3 @@ resources:
- metadata-service.yaml
- metadata-envoy-deployment.yaml
- metadata-envoy-service.yaml
- mlmd-server-configmap.yaml

29 changes: 18 additions & 11 deletions manifests/kustomize/base/metadata/metadata-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,17 +18,24 @@ spec:
- name: container
image: gcr.io/tfx-oss-public/ml_metadata_store_server:0.14.0
env:
- name: GRPC_PORT
value: "8080"
- name: METADATA_STORE_SERVER_CONFIG_FILE
value: "/etc/config/mlmd_config.prototxt"
- name: DBCONFIG_USER
valueFrom:
secretKeyRef:
name: mysql-credential
key: username
- name: DBCONFIG_PASSWORD
valueFrom:
secretKeyRef:
name: mysql-credential
key: password
command: ["/bin/metadata_store_server"]
args: ["--grpc_port=8080",
"--mysql_config_host=mysql",
"--mysql_config_database=metadb",
"--mysql_config_port=3306",
"--mysql_config_user=$(DBCONFIG_USER)",
"--mysql_config_password=$(DBCONFIG_PASSWORD)"
]
ports:
- name: md-backendapi
containerPort: 8080
volumeMounts:
- name: mlmd-server-config-volume
mountPath: /etc/config
volumes:
- name: mlmd-server-config-volume
configMap:
name: mlmd-service-configmap
17 changes: 0 additions & 17 deletions manifests/kustomize/base/metadata/mlmd-server-configmap.yaml

This file was deleted.

0 comments on commit 4522171

Please sign in to comment.