fix(backend): improve forward / backward compatibility on db status t…

…able (#4351)
kubeflow · Aug 13, 2020 · 384afac · 384afac
1 parent 5ec7ec8
commit 384afac
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/backend/src/apiserver/storage/db_status_store.go b/backend/src/apiserver/storage/db_status_store.go
@@ -29,6 +29,12 @@ type DBStatusStoreInterface interface {
 	MarkSampleLoaded() error
 }
 
+var (
+	dbStatusStoreColumns = []string{
+		"HaveSamplesLoaded",
+	}
+)
+
 // Implementation of a DBStatusStoreInterface. This store read/write state of the database.
 // For now we store status like whether sample is loaded.
 type DBStatusStore struct {
@@ -77,7 +83,7 @@ func (s *DBStatusStore) InitializeDBStatusTable() error {
 
 func (s *DBStatusStore) HaveSamplesLoaded() (bool, error) {
 	var haveSamplesLoaded bool
-	sql, args, err := sq.Select("*").From("db_statuses").ToSql()
+	sql, args, err := sq.Select(dbStatusStoreColumns...).From("db_statuses").ToSql()
 	if err != nil {
 		return false, util.NewInternalServerError(err, "Error creating query to get load sample status.")
 	}