Skip to content

Commit

Permalink
Reduce ttl of persisted final workflow to 1 day (#4005)
Browse files Browse the repository at this point in the history
* reduce ttl of pesisted final workflow to 1 day

* add comment

* enable pagination when expanding experiment in both the home page and the archive page

* Revert "enable pagination when expanding experiment in both the home page and the archive page"

This reverts commit 5b67273.

* Address comments
  • Loading branch information
jingzhang36 authored and Bobgy committed Sep 11, 2020
1 parent 9c4e864 commit 135715d
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
4 changes: 2 additions & 2 deletions backend/Dockerfile.persistenceagent
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ COPY --from=builder /go/src/github.com/kubeflow/pipelines/third_party/license.tx

ENV NAMESPACE ""

# Set Workflow TTL to 7 days
ENV TTL_SECONDS_AFTER_WORKFLOW_FINISH 604800
# Set Workflow TTL to 1 day. The way to use a different value for a particular Kubeflow Pipelines deployment is demonstrated in manifests/kustomize/base/pipeline/ml-pipeline-persistenceagent-deployment.yaml
ENV TTL_SECONDS_AFTER_WORKFLOW_FINISH 86400

CMD persistence_agent --logtostderr=true --namespace=${NAMESPACE} --ttlSecondsAfterWorkflowFinish=${TTL_SECONDS_AFTER_WORKFLOW_FINISH}
Original file line number Diff line number Diff line change
Expand Up @@ -514,6 +514,8 @@ spec:
- env:
- name: NAMESPACE
value: {{ .Release.Namespace }}
- name: TTL_SECONDS_AFTER_WORKFLOW_FINISH
value: "86400"
image: {{ .Values.images.persistenceagent }}
imagePullPolicy: IfNotPresent
name: ml-pipeline-persistenceagent
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ spec:
valueFrom:
fieldRef:
fieldPath: metadata.namespace
- name: TTL_SECONDS_AFTER_WORKFLOW_FINISH
value: "86400"
image: gcr.io/ml-pipeline/persistenceagent:dummy
imagePullPolicy: IfNotPresent
name: ml-pipeline-persistenceagent
Expand Down

0 comments on commit 135715d

Please sign in to comment.