Stops k8s-helper from crashing when pod has no logs (#540)

kubeflow · Dec 15, 2018 · 10c009d · 10c009d
1 parent 230043a
commit 10c009d
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/frontend/server/k8s-helper.ts b/frontend/server/k8s-helper.ts
@@ -122,7 +122,8 @@ export function getPodLogs(podName: string): Promise<string> {
     throw new Error('Cannot access kubernetes API');
   }
   return (k8sV1Client.readNamespacedPodLog(podName, namespace, 'main') as any)
-    .then((response: any) => response.body.toString(), (error: any) => {
-      throw new Error(JSON.stringify(error.body));
-    });
+    .then(
+      (response: any) => (response && response.body) ? response.body.toString() : '',
+      (error: any) => { throw new Error(JSON.stringify(error.body)); }
+    );
 }