Skip to content

Commit

Permalink
SDK - Components - Python - Switched the default base image to python…
Browse files Browse the repository at this point in the history 
… 3.7 (4054)

Previously the default image was set to an old version of tensorflow image. That image is now outdated. It's also framework-specific and pretty big.
We're switching to the official python image which is small, official and framework-agnostic.
The users can easily switch to the old behavior by just specifying `base_image='tensorflow/tensorflow:1.13.2-py3'` during the component creation.
  • Loading branch information
@Ark-kun @Bobgy
Ark-kun authored and Bobgy committed Jul 2, 2020
1 parent 6ced6ea commit 090fffc
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 15 deletions.
7 changes: 3 additions & 4 deletions sdk/python/kfp/components/_python_op.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,7 @@ def make_parent_dirs_and_return_path(file_path: str):
return make_parent_dirs_and_return_path


#TODO: Replace this image name with another name once people decide what to replace it with.
default_base_image_or_builder='tensorflow/tensorflow:1.13.2-py3'
default_base_image_or_builder='python:3.7'


def _python_function_name_to_component_name(name):
Expand Down Expand Up @@ -410,7 +409,7 @@ def _func_to_component_spec(func, extra_code='', base_image : str = None, packag
Args:
func: Required. The function to be converted
base_image: Optional. Docker image to be used as a base image for the python component. Must have python 3.5+ installed. Default is tensorflow/tensorflow:1.11.0-py3
base_image: Optional. Docker image to be used as a base image for the python component. Must have python 3.5+ installed. Default is python:3.7
Note: The image can also be specified by decorating the function with the @python_component decorator. If different base images are explicitly specified in both places, an error is raised.
extra_code: Optional. Python source code that gets placed before the function code. Can be used as workaround to define types used in function signature.
packages_to_install: Optional. List of [versioned] python packages to pip install before executing the user function.
Expand Down Expand Up @@ -665,7 +664,7 @@ def add_multiply_two_numbers(a: float, b: float) -> NamedTuple('DummyName', [('s
Args:
func: The python function to convert
base_image: Optional. Specify a custom Docker container image to use in the component. For lightweight components, the image needs to have python 3.5+. Default is tensorflow/tensorflow:1.13.2-py3
base_image: Optional. Specify a custom Docker container image to use in the component. For lightweight components, the image needs to have python 3.5+. Default is python:3.7
extra_code: Optional. Extra code to add before the function code. Can be used as workaround to define types used in function signature.
packages_to_install: Optional. List of [versioned] python packages to pip install before executing the user function.
modules_to_capture: Optional. List of module names that will be captured (instead of just referencing) during the dependency scan. By default the func.__module__ is captured. The actual algorithm: Starting with the initial function, start traversing dependencies. If the dependecy.__module__ is in the modules_to_capture list then it's captured and it's dependencies are traversed. Otherwise the dependency is only referenced instead of capturing and its dependencies are not traversed.
Expand Down
22 changes: 11 additions & 11 deletions sdk/python/tests/compiler/testdata/parallelfor_item_argument_resolving.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ spec:
_parsed_args = vars(_parser.parse_args())
_outputs = consume(**_parsed_args)
image: "tensorflow/tensorflow:1.13.2-py3"
image: "python:3.7"
inputs:
parameters:
-
Expand Down Expand Up @@ -59,7 +59,7 @@ spec:
_parsed_args = vars(_parser.parse_args())
_outputs = consume(**_parsed_args)
image: "tensorflow/tensorflow:1.13.2-py3"
image: "python:3.7"
inputs:
parameters:
-
Expand Down Expand Up @@ -89,7 +89,7 @@ spec:
_parsed_args = vars(_parser.parse_args())
_outputs = consume(**_parsed_args)
image: "tensorflow/tensorflow:1.13.2-py3"
image: "python:3.7"
inputs:
parameters:
-
Expand Down Expand Up @@ -119,7 +119,7 @@ spec:
_parsed_args = vars(_parser.parse_args())
_outputs = consume(**_parsed_args)
image: "tensorflow/tensorflow:1.13.2-py3"
image: "python:3.7"
inputs:
parameters:
-
Expand Down Expand Up @@ -149,7 +149,7 @@ spec:
_parsed_args = vars(_parser.parse_args())
_outputs = consume(**_parsed_args)
image: "tensorflow/tensorflow:1.13.2-py3"
image: "python:3.7"
inputs:
parameters:
-
Expand Down Expand Up @@ -179,7 +179,7 @@ spec:
_parsed_args = vars(_parser.parse_args())
_outputs = consume(**_parsed_args)
image: "tensorflow/tensorflow:1.13.2-py3"
image: "python:3.7"
inputs:
parameters:
-
Expand Down Expand Up @@ -209,7 +209,7 @@ spec:
_parsed_args = vars(_parser.parse_args())
_outputs = consume(**_parsed_args)
image: "tensorflow/tensorflow:1.13.2-py3"
image: "python:3.7"
inputs:
parameters:
-
Expand Down Expand Up @@ -417,7 +417,7 @@ spec:
pass
with open(output_file, 'w') as f:
f.write(_output_serializers[idx](_outputs[idx]))
image: "tensorflow/tensorflow:1.13.2-py3"
image: "python:3.7"
metadata:
labels:
pipelines.kubeflow.org/pipeline-sdk-type: kfp
Expand Down Expand Up @@ -481,7 +481,7 @@ spec:
pass
with open(output_file, 'w') as f:
f.write(_output_serializers[idx](_outputs[idx]))
image: "tensorflow/tensorflow:1.13.2-py3"
image: "python:3.7"
metadata:
labels:
pipelines.kubeflow.org/pipeline-sdk-type: kfp
Expand Down Expand Up @@ -545,7 +545,7 @@ spec:
pass
with open(output_file, 'w') as f:
f.write(_output_serializers[idx](_outputs[idx]))
image: "tensorflow/tensorflow:1.13.2-py3"
image: "python:3.7"
metadata:
labels:
pipelines.kubeflow.org/pipeline-sdk-type: kfp
Expand Down Expand Up @@ -603,7 +603,7 @@ spec:
pass
with open(output_file, 'w') as f:
f.write(_output_serializers[idx](_outputs[idx]))
image: "tensorflow/tensorflow:1.13.2-py3"
image: "python:3.7"
metadata:
labels:
pipelines.kubeflow.org/pipeline-sdk-type: kfp
Expand Down

0 comments on commit 090fffc

Please sign in to comment.