feat(ws): Add Empty State to Workspace list

[liavweiss]

fix #259

[google-oss-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ederign for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• workspaces/frontend/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[paulovmr]

/ok-to-test

[paulovmr]

Hi @liavweiss , thanks for the PR. Please consider extracting the empty state from the WorkspaceKinds.tsx file as a reusable component and use it here, also including the CLEAR ALL FILTERS button.

[jenny-s51]

Suggested change

	<Td colSpan={11} id="empty-state">
	<Td colSpan={12} id="empty-state">

The table has 12 columns including the columnNames and the two actions columns.

[jenny-s51]

Thanks for implementing the empty state in the workspace table @liavweiss! Great work.

A couple of suggestions for improvement:

• I agree with @paulovmr - we should extract the empty state component into a dedicated reusable component to ensure consistency when we need similar empty states elsewhere.

• Can we also include a "Clear all filters" button in the empty state so the users can easily click the action button to recover from the empty state? https://www.patternfly.org/components/empty-state/#no-match-found is a good example of this in action.

[ederign]

/retitle feat(ws): Add Empty State to Workspace list

[liavweiss]

Hey @jenny-s51 and @paulovmr, I made the suggested changes.

[jenny-s51]

Thank you @liavweiss ! New extracted component looks good.

We will have to apply your extracted component in the Workspace Creation Wizard steps as well - the components would be:

• WorkspaceCreationKindList.tsx
• WorkspaceCreationImageList.tsx
• WorkspaceCreationPodConfigList.tsx

It's fine to do that in a separate PR if this is out of scope here, would you mind opening a follow-up issue to address those remaining instances above? Thank you!

[jenny-s51]

Suggested change

	<Td colSpan={11} id="empty-state-cell">
	<Td colSpan={12} id="empty-state-cell">