Allow run as root for Intel MPI

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
kubeflow · Jan 1, 2025 · a0eebcd · a0eebcd
1 parent bce83b6
commit a0eebcd
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/test/e2e/mpi_job_test.go b/test/e2e/mpi_job_test.go
@@ -227,10 +227,10 @@ var _ = ginkgo.Describe("MPIJob", func() {
 					Image:           intelMPIImage,
 					ImagePullPolicy: corev1.PullIfNotPresent, // use locally built image.
 					Command:         []string{},              // uses entrypoint.
-					Args: []string{
-						"/usr/sbin/sshd",
-						"-De",
-					},
+					//Args: []string{
+					//	"/usr/sbin/sshd",
+					//	"-De",
+					//},
 					ReadinessProbe: &corev1.Probe{
 						ProbeHandler: corev1.ProbeHandler{
 							TCPSocket: &corev1.TCPSocketAction{
@@ -245,6 +245,8 @@ var _ = ginkgo.Describe("MPIJob", func() {
 
 		ginkgo.When("running as root", func() {
 			ginkgo.It("should succeed", func() {
+				launcherContainer := &mpiJob.Spec.MPIReplicaSpecs[kubeflow.MPIReplicaTypeLauncher].Template.Spec.Containers[0]
+				launcherContainer.Command = append(launcherContainer.Command, "--allow-run-as-root")
 				mpiJob := createJobAndWaitForCompletion(mpiJob)
 				expectConditionToBeTrue(mpiJob, kubeflow.JobSucceeded)
 			})
@@ -261,7 +263,8 @@ var _ = ginkgo.Describe("MPIJob", func() {
 				workerContainer.SecurityContext = &corev1.SecurityContext{
 					RunAsUser: ptr.To[int64](1000),
 				}
-				workerContainer.Args = append(workerContainer.Args, "-f", "/home/mpiuser/.sshd_config")
+				//workerContainer.Args = append(workerContainer.Args, "-f", "/home/mpiuser/.sshd_config")
+				workerContainer.Args = append(workerContainer.Args, "/usr/sbin/sshd", "-De", "-f", "/home/mpiuser/.sshd_config")
 			})
 
 			ginkgo.It("should succeed", func() {