Automated cherry pick of #1393: Check in expected kpt output for Kptfile refactoring #1398: Convert v1 to v2 setters & substituions in gcp Cherry pick of #1393 #1398 on v1.1-branch. #1393: Check in expected kpt output for Kptfile refactoring #1398: Convert v1 to v2 setters & substituions in gcp #1401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 21, 2020 06:26
* Per GoogleCloudPlatform/kubeflow-distribution#89 we need to get rid of the legacy partial setters and move to using a KptFile and substitutions. * In preparation for that we want to check in a set of test data that is the result of running our kpt cfg set with a given set of values * This test data will be used to verify that the refactoring to use a KptFile doesn't change the output. * After adding the KptFile we can simply regenerate the testdata and then look at the diff to ensure there are no unexpected changes.
* The latest version of kpt started choking on gcp/v2 because we were still using the old style setters and substitutions. * This PR creates a kptfile to use the new setter and substitutions. * hack/create_kptfile.py contains a script to generate lot of the setters and substitutions. * kf-vm-sa.yaml shouldn't specify the namespace; this will get set in an overlay * Move workload identity bindings for kf-admin KSA from kubeflow/instance in gcp blueprints repo into this repository. related to gcp-blueprints#89
|
This change is |
|
//approve |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.