Fix hard coded "name" variable in example prototypes #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the hard coded "name" variable in the example prototypes so that it can take the value from parameters.
|
/ok-to-test |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankushagarwal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
saffaalvi
pushed a commit
to StatCan/kubeflow
that referenced
this pull request
Feb 11, 2021
This fixes the hard coded "name" variable in the example prototypes so that it can take the value from parameters.
yanniszark
pushed a commit
to arrikto/kubeflow
that referenced
this pull request
Feb 15, 2021
surajkota
pushed a commit
to surajkota/kubeflow
that referenced
this pull request
Jun 13, 2022
* Use a configmap generator for the spawner_ui_config.yaml
* Using a configmap generator is a bit cleaner because we can store
the configuration file in a external file rather than inlining it in
the config map.
* Using a configmap generator also has the advantage that kustomize will
generate a unique name based on a hash of the content.
* This has the advantage that if a user updates the config, the hash
would change so deployments would automatically be redeployed in order
to pick up the config changes.
* Also update the default image used in the configmap to fix kubeflow#1010
* Rebase and regenerate the tests.
* * The deployment for the UI needs to use the original name of
the jupyter web app config map without the prefix/suffix.
* Update expected tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the hard coded "name" variable in the example prototypes so that it can take the value from exposed parameters and be compatible with the user guide.
The other hard coded variables remain as-is to keep it simple. However they could also be modified in the same way, if needed.
This change is