Add volumemount support and fix parameter bugs #40
Conversation
| @@ -115,11 +115,11 @@ def _create_pipeline_workflow(self, args, pipeline, op_transformers=None, pipeli | |||
| for tp in task.get('params', []): | |||
| if tp['name'] in pipeline_param_names: | |||
| tp['value'] = '$(params.%s)' % tp['name'] | |||
| break | |||
sdk/python/tests/compiler/testdata/watson_train_serve_pipeline.py
Outdated
Show resolved
Hide resolved
Tomcli
changed the title
|
The volumes support (not ops) itself is not pending the pr, but in order to run the watson ML with our current implementation, kubeflow/pipelines#3316 is necessary. |
| @@ -1,4 +1,4 @@ | |||
| # Copyright 2018 Google LLC | |||
| # Copyright 2020 Google LLC | |||
There was a problem hiding this comment.
should this also say kubeflow.org instead of Google LLC ? (cc @animeshsingh)
There was a problem hiding this comment.
Oh i was coping from the kubeflow example, I can update the header
There was a problem hiding this comment.
yeah all licenses should be kubeflow.org
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: animeshsingh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* add volumemount support and fix parameter bugs * remove sdk/samples folder and use real kfp example * fix formatting * update unittest and instructions * update license header * update license header * update license
feat(frontend): Update GitHub References in UI to point to ODH Repo Fork
Preview for volumemount support. Tekton needs to pass param under path
/tekton/results/. Pending with PR kubeflow/pipelines#3316 to get the config path support on the watson example.Fixes #34
This change is