Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove dep ensure in CI #525

Merged
merged 6 commits into from
May 15, 2019
Merged

chore: Remove dep ensure in CI #525

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
078e322
chore: Move unit test before image building in v1alpha2
gaocegege May 15, 2019
4d9f50a
fix: Move python suggestions build to dep
gaocegege May 15, 2019
1c230bd
chore: Move more layers to dep
gaocegege May 15, 2019
c4c742c
chore: Add dep and remove depensure in CI
gaocegege May 15, 2019
e60501c
fix: Run setup cluster later
gaocegege May 15, 2019
ad841ef
fix: Address comments
gaocegege May 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Run setup cluster later 
Signed-off-by: Ce Gao <gaoce@caicloud.io>
  • Loading branch information
@gaocegege
gaocegege committed May 15, 2019
commit e60501ce85f688ca2968552552f2b4ac346bcf1d
10 changes: 6 additions & 4 deletions test/workflows/components/workflows-v1alpha1.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,10 +208,6 @@
name: "python-tests",
template: "python-tests",
},
{
name: "setup-cluster",
template: "setup-cluster",
},
{
name: "build-suggestion-bo",
template: "build-suggestion-bo",
Expand Down Expand Up @@ -257,6 +253,12 @@
template: "create-pr-symlink",
},
],
[
{
name: "setup-cluster",
template: "setup-cluster",
},
],
[
{
name: "unit-test",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit tests not changed in v1alpha1?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot change it, because v1alpha1 unit test should be run after the cluster is created.

Expand Down
10 changes: 6 additions & 4 deletions test/workflows/components/workflows-v1alpha2.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,10 +204,6 @@
template: "checkout",
}],
[
{
name: "setup-cluster",
template: "setup-cluster",
},
{
name: "python-tests",
template: "python-tests",
Expand Down Expand Up @@ -261,6 +257,12 @@
template: "create-pr-symlink",
},
],
[
{
name: "setup-cluster",
template: "setup-cluster",
},
],
[
{
name: "run-tests",
Expand Down